You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by weitao zhou <zh...@gmail.com> on 2015/06/01 14:00:40 UTC
Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
return the statistics yet now
Diffs
-----
src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a
Diff: https://reviews.apache.org/r/34886/diff/
Testing
-------
Thanks,
weitao zhou
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by haosdent huang <ha...@gmail.com>.
> On June 1, 2015, 1:24 p.m., haosdent huang wrote:
> > Ship It!
The patch looks good for me. But I think you need find a committer to review this and ask more advice :-) .
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review85974
-----------------------------------------------------------
On June 1, 2015, 12:16 p.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34886/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 12:16 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2787
> https://issues.apache.org/jira/browse/MESOS-2787
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
> when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
> return the statistics yet now
>
>
> Diffs
> -----
>
> src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a
>
> Diff: https://reviews.apache.org/r/34886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review85974
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On June 1, 2015, 12:16 p.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34886/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 12:16 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2787
> https://issues.apache.org/jira/browse/MESOS-2787
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
> when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
> return the statistics yet now
>
>
> Diffs
> -----
>
> src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a
>
> Diff: https://reviews.apache.org/r/34886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by weitao zhou <zh...@gmail.com>.
> On 六月 1, 2015, 6:41 p.m., Ben Mahler wrote:
> > src/cli/mesos-ps, line 138
> > <https://reviews.apache.org/r/34886/diff/1/?file=975641#file975641line138>
> >
> > s/+/ + /
@Ben, can we ship it now? :-)
- weitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review86038
-----------------------------------------------------------
On 六月 2, 2015, 2:29 a.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34886/
> -----------------------------------------------------------
>
> (Updated 六月 2, 2015, 2:29 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2787
> https://issues.apache.org/jira/browse/MESOS-2787
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
> when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
> return the statistics yet now
>
>
> Diffs
> -----
>
> src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753
>
> Diff: https://reviews.apache.org/r/34886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review86038
-----------------------------------------------------------
Thanks! Looks good, just two minor comments.
src/cli/mesos-ps
<https://reviews.apache.org/r/34886/#comment137888>
Should this line also be checking that 'mem_limit_bytes' is not None?
src/cli/mesos-ps
<https://reviews.apache.org/r/34886/#comment137890>
s/+/ + /
- Ben Mahler
On June 1, 2015, 12:16 p.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34886/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 12:16 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2787
> https://issues.apache.org/jira/browse/MESOS-2787
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
> when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
> return the statistics yet now
>
>
> Diffs
> -----
>
> src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a
>
> Diff: https://reviews.apache.org/r/34886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by weitao zhou <zh...@gmail.com>.
> On 六月 2, 2015, 2:19 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp, line 104
> > <https://reviews.apache.org/r/34886/diff/2/?file=976113#file976113line104>
> >
> > You need `git rebase master` first.
thanks, mate, I am not good at this Review board. It's okay now, give a review plz.
- weitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review86143
-----------------------------------------------------------
On 六月 2, 2015, 2:29 a.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34886/
> -----------------------------------------------------------
>
> (Updated 六月 2, 2015, 2:29 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2787
> https://issues.apache.org/jira/browse/MESOS-2787
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
> when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
> return the statistics yet now
>
>
> Diffs
> -----
>
> src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753
>
> Diff: https://reviews.apache.org/r/34886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review86143
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp
<https://reviews.apache.org/r/34886/#comment138066>
You need `git rebase master` first.
- haosdent huang
On June 2, 2015, 2:14 a.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34886/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 2:14 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2787
> https://issues.apache.org/jira/browse/MESOS-2787
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
> when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
> return the statistics yet now
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 61a405f225d14acbc38a80d35570426cb05a3d0a
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
> 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp a6e8ba943d97ae908122a444332155ebc6c7bb93
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
> docs/configuration.md 4e20913cf7a088997235f399733c89db3441fb7c
> docs/fetcher-cache-internals.md c696f1529709f5a0a51286f5f7d3dbfe39bd2ac1
> docs/fetcher.md 638f5305a24fe7dbf459c937872a295e8edd5d44
> docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725
> docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b
> docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7
> docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5
> docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b
> docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e
> include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797
> include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4
> include/mesos/slave/isolator.hpp 18edc030367e42240090f2f3dbc92aec7a4c6234
> include/mesos/type_utils.hpp 52380c2461841026ee492797b4d8081f944f7b7b
> src/Makefile.am a5a7306b1ef65ca2b643653779ab76c26dbb5c90
> src/cli/execute.cpp b387b64e7ed88ac9626fe09ced0dceb807b584bd
> src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753
> src/cli/mesos.cpp 1121e193b4c8f8f0144473f8afa88a2991db933c
> src/cli/resolve.cpp 74545a0a14878e1eb704c63209f28c08c337912f
> src/common/resources.cpp 01c79fbbf16bcbdc7a25953c49107863fce3e87f
> src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d
> src/examples/load_generator_framework.cpp 6e83308974aa0eeae69b82be56ca5cff2c6b2ec0
> src/examples/low_level_scheduler_libprocess.cpp bd228fd178d639146fe237794c39872dab9085cb
> src/examples/low_level_scheduler_pthread.cpp 81388f145ede3803ed5a533797a25d910d467316
> src/examples/persistent_volume_framework.cpp 6a0c0cb61a06d1a0e7608fe2447167c18111ea43
> src/hdfs/hdfs.hpp 0b0312c3704daa2e426c9a4eba3f6e82616ea032
> src/health-check/main.cpp 3607479848f0e03b0886e3ae84ff92ecb32c33f7
> src/launcher/executor.cpp f79dc60943bcdf52185cc790d4883c603a5a110a
> src/launcher/fetcher.cpp c32106ff0c99f3161c1c2eb1fa5329a9ce4c5fe9
> src/linux/routing/handle.hpp aed810ed97f29fb79d13feb6fa72ce4360e8623b
> src/linux/routing/queueing/fq_codel.cpp 4dc2a9d2ed52937f0a78a083980db488c06b45a7
> src/local/main.cpp ec21ed008354d4f14d7b9276b7dfbd6a64e661e9
> src/log/tool/benchmark.hpp 5714b87323a9f291c3fb633b9a2c6b8b7b6f4594
> src/log/tool/benchmark.cpp 4895dd8812954939bbef4eb8bbba20cfbde592f9
> src/log/tool/initialize.hpp dc25e974d5aecb4d350fafe87cac84885951d6f1
> src/log/tool/initialize.cpp a5146fd81e9657d4f4eb85fe09a73c43ff7635fa
> src/log/tool/read.hpp f5958cd5abd49d773ef66a9b14853c5f3095a28b
> src/log/tool/read.cpp 08d1932be3f43f7e4f4117c630a88df2ebdfafe4
> src/log/tool/replica.hpp 7a8f391491295b930d55c2a27f8522bec7bc6dc9
> src/log/tool/replica.cpp 1eba4803f0129a1c2341cedfd4204f00ff69408f
> src/master/main.cpp 3d490c3a5cad59eb908054c3c3872d5540f45b8c
> src/slave/constants.hpp 84927e589499e989249c217db571bbeb84a88af1
> src/slave/containerizer/docker.hpp 395d5352ad70ed4b7f954d82b1b93e18ca4b74e5
> src/slave/containerizer/docker.cpp 41e0b98c387e57b692df4c56ae21ce70f67f9a19
> src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f
> src/slave/containerizer/fetcher.cpp f77652b65671c3a63c17960490bbc66d29f5439d
> src/slave/containerizer/isolator.cpp d51ecc9347cafef90c92a6965e37f417b4929e79
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 2118c97d4f3d2e58fab62c6e99d5bec6f4df8bbd
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 5bd352549553fc0caf62bf116deb5cece35679c6
> src/slave/containerizer/isolators/cgroups/mem.hpp dc752014236b69d34c6b33a06fc00580780b0b4c
> src/slave/containerizer/isolators/cgroups/mem.cpp 9647e79fd27ed08f1d86d13ea1e2ab98de3367c7
> src/slave/containerizer/isolators/cgroups/perf_event.hpp 560cd0359a2795a937335efa30dc380a60fcb540
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153fd8d15e4c8651d606eb7770d30674d2a0c
> src/slave/containerizer/isolators/filesystem/shared.hpp 08c6ffea0e2fada8e0b04f4ab15d8569c5416a8e
> src/slave/containerizer/isolators/filesystem/shared.cpp 5049306dea7b94dfaa4f7c2d8187bbae8c360633
> src/slave/containerizer/isolators/namespaces/pid.hpp 6b24e2990311d0b09b3f6f2bb4ab29ee83fddddc
> src/slave/containerizer/isolators/namespaces/pid.cpp c6b28aa70415f4d88b14f0eeff7f20c35018fbdc
> src/slave/containerizer/isolators/network/port_mapping.hpp 9f83af17e9e2967ac1e3b4c83380f8be49ce863c
> src/slave/containerizer/isolators/network/port_mapping.cpp 781c35be4c6edd45bf501f732be6283fa99a9d2e
> src/slave/containerizer/isolators/posix.hpp 271061ef97aea96bb816982e530c84554d4b08d8
> src/slave/containerizer/isolators/posix/disk.hpp 5dfa815edaee9b17c19ae2a7491e63c545c8ab1f
> src/slave/containerizer/isolators/posix/disk.cpp b2f995cba36b1399db48af1de49d76c607f80abd
> src/slave/containerizer/mesos/containerizer.hpp 3ac2387eabded61c897a5016655aae10cd1bca91
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
> src/slave/flags.hpp 84dbb8a2aa963bb38cf0f610ab442b626179b173
> src/slave/flags.cpp ab8709861eb037e75dd2e91a097048ea6cd20c9c
> src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
> src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
> src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e
> src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e
> src/tests/fetcher_cache_tests.cpp cbd44b98d19953d174fac977f509d4900a37481f
> src/tests/fetcher_tests.cpp 361d918db183d31ef00e414e8b991846a9172be8
> src/tests/isolator.hpp fd6aec74edf49153d31b559d56e8e06c15836f68
> src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1
> src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b
> src/tests/mesos.hpp c00adb1d5665c86b18a468f41e7e658eebbb4959
> src/tests/mesos.cpp d3a8bb70478993883f34804c8e2d7559d16c3538
> src/tests/port_mapping_tests.cpp f8372df74cd71df37de4a2438069ef0ea8878512
> src/tests/resources_tests.cpp b4a9bbf5dab0329b89da732d2b27c3ab0b118260
> src/usage/main.cpp 86fd79628c29ba8ca9ef04ff00102aa254f10b03
>
> Diff: https://reviews.apache.org/r/34886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review86200
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34886]
All tests passed.
- Mesos ReviewBot
On June 2, 2015, 2:29 a.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34886/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 2:29 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2787
> https://issues.apache.org/jira/browse/MESOS-2787
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
> when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
> return the statistics yet now
>
>
> Diffs
> -----
>
> src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753
>
> Diff: https://reviews.apache.org/r/34886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by weitao zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/
-----------------------------------------------------------
(Updated 六月 2, 2015, 2:29 a.m.)
Review request for mesos.
Bugs: MESOS-2787
https://issues.apache.org/jira/browse/MESOS-2787
Repository: mesos
Description
-------
The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
return the statistics yet now
Diffs (updated)
-----
src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753
Diff: https://reviews.apache.org/r/34886/diff/
Testing
-------
Thanks,
weitao zhou
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by weitao zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/
-----------------------------------------------------------
(Updated 六月 2, 2015, 2:14 a.m.)
Review request for mesos.
Bugs: MESOS-2787
https://issues.apache.org/jira/browse/MESOS-2787
Repository: mesos
Description
-------
The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
return the statistics yet now
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 61a405f225d14acbc38a80d35570426cb05a3d0a
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 8d5217a699a302cc9ebb2aa10d74cced7eb2b3d9
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp a6e8ba943d97ae908122a444332155ebc6c7bb93
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp f1ae80ab881ccfcefda69d5bfee2d969d171f1b9
docs/configuration.md 4e20913cf7a088997235f399733c89db3441fb7c
docs/fetcher-cache-internals.md c696f1529709f5a0a51286f5f7d3dbfe39bd2ac1
docs/fetcher.md 638f5305a24fe7dbf459c937872a295e8edd5d44
docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725
docs/images/fetch_evict1.jpg c237686f89e2deb5888bf078c2bbd5f49d26b68b
docs/images/fetch_evict2.jpg 65d32af355126cee7759cfe1de96ad86c8c7f6f7
docs/images/fetch_evict3.jpg d939cc05913d194386a88f949ad2fe66b0d671b5
docs/images/fetch_flow.jpg 872a64f3e8a6cfb11c5a0520acab1807e7252e5b
docs/images/fetch_state.jpg 378693f57627d68caef07b1b1db1b6e143cb962e
include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797
include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4
include/mesos/slave/isolator.hpp 18edc030367e42240090f2f3dbc92aec7a4c6234
include/mesos/type_utils.hpp 52380c2461841026ee492797b4d8081f944f7b7b
src/Makefile.am a5a7306b1ef65ca2b643653779ab76c26dbb5c90
src/cli/execute.cpp b387b64e7ed88ac9626fe09ced0dceb807b584bd
src/cli/mesos-ps 8ca7a64d0ab6f0b8db823ca95d5f7500487b8753
src/cli/mesos.cpp 1121e193b4c8f8f0144473f8afa88a2991db933c
src/cli/resolve.cpp 74545a0a14878e1eb704c63209f28c08c337912f
src/common/resources.cpp 01c79fbbf16bcbdc7a25953c49107863fce3e87f
src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d
src/examples/load_generator_framework.cpp 6e83308974aa0eeae69b82be56ca5cff2c6b2ec0
src/examples/low_level_scheduler_libprocess.cpp bd228fd178d639146fe237794c39872dab9085cb
src/examples/low_level_scheduler_pthread.cpp 81388f145ede3803ed5a533797a25d910d467316
src/examples/persistent_volume_framework.cpp 6a0c0cb61a06d1a0e7608fe2447167c18111ea43
src/hdfs/hdfs.hpp 0b0312c3704daa2e426c9a4eba3f6e82616ea032
src/health-check/main.cpp 3607479848f0e03b0886e3ae84ff92ecb32c33f7
src/launcher/executor.cpp f79dc60943bcdf52185cc790d4883c603a5a110a
src/launcher/fetcher.cpp c32106ff0c99f3161c1c2eb1fa5329a9ce4c5fe9
src/linux/routing/handle.hpp aed810ed97f29fb79d13feb6fa72ce4360e8623b
src/linux/routing/queueing/fq_codel.cpp 4dc2a9d2ed52937f0a78a083980db488c06b45a7
src/local/main.cpp ec21ed008354d4f14d7b9276b7dfbd6a64e661e9
src/log/tool/benchmark.hpp 5714b87323a9f291c3fb633b9a2c6b8b7b6f4594
src/log/tool/benchmark.cpp 4895dd8812954939bbef4eb8bbba20cfbde592f9
src/log/tool/initialize.hpp dc25e974d5aecb4d350fafe87cac84885951d6f1
src/log/tool/initialize.cpp a5146fd81e9657d4f4eb85fe09a73c43ff7635fa
src/log/tool/read.hpp f5958cd5abd49d773ef66a9b14853c5f3095a28b
src/log/tool/read.cpp 08d1932be3f43f7e4f4117c630a88df2ebdfafe4
src/log/tool/replica.hpp 7a8f391491295b930d55c2a27f8522bec7bc6dc9
src/log/tool/replica.cpp 1eba4803f0129a1c2341cedfd4204f00ff69408f
src/master/main.cpp 3d490c3a5cad59eb908054c3c3872d5540f45b8c
src/slave/constants.hpp 84927e589499e989249c217db571bbeb84a88af1
src/slave/containerizer/docker.hpp 395d5352ad70ed4b7f954d82b1b93e18ca4b74e5
src/slave/containerizer/docker.cpp 41e0b98c387e57b692df4c56ae21ce70f67f9a19
src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f
src/slave/containerizer/fetcher.cpp f77652b65671c3a63c17960490bbc66d29f5439d
src/slave/containerizer/isolator.cpp d51ecc9347cafef90c92a6965e37f417b4929e79
src/slave/containerizer/isolators/cgroups/cpushare.hpp 2118c97d4f3d2e58fab62c6e99d5bec6f4df8bbd
src/slave/containerizer/isolators/cgroups/cpushare.cpp 5bd352549553fc0caf62bf116deb5cece35679c6
src/slave/containerizer/isolators/cgroups/mem.hpp dc752014236b69d34c6b33a06fc00580780b0b4c
src/slave/containerizer/isolators/cgroups/mem.cpp 9647e79fd27ed08f1d86d13ea1e2ab98de3367c7
src/slave/containerizer/isolators/cgroups/perf_event.hpp 560cd0359a2795a937335efa30dc380a60fcb540
src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153fd8d15e4c8651d606eb7770d30674d2a0c
src/slave/containerizer/isolators/filesystem/shared.hpp 08c6ffea0e2fada8e0b04f4ab15d8569c5416a8e
src/slave/containerizer/isolators/filesystem/shared.cpp 5049306dea7b94dfaa4f7c2d8187bbae8c360633
src/slave/containerizer/isolators/namespaces/pid.hpp 6b24e2990311d0b09b3f6f2bb4ab29ee83fddddc
src/slave/containerizer/isolators/namespaces/pid.cpp c6b28aa70415f4d88b14f0eeff7f20c35018fbdc
src/slave/containerizer/isolators/network/port_mapping.hpp 9f83af17e9e2967ac1e3b4c83380f8be49ce863c
src/slave/containerizer/isolators/network/port_mapping.cpp 781c35be4c6edd45bf501f732be6283fa99a9d2e
src/slave/containerizer/isolators/posix.hpp 271061ef97aea96bb816982e530c84554d4b08d8
src/slave/containerizer/isolators/posix/disk.hpp 5dfa815edaee9b17c19ae2a7491e63c545c8ab1f
src/slave/containerizer/isolators/posix/disk.cpp b2f995cba36b1399db48af1de49d76c607f80abd
src/slave/containerizer/mesos/containerizer.hpp 3ac2387eabded61c897a5016655aae10cd1bca91
src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
src/slave/flags.hpp 84dbb8a2aa963bb38cf0f610ab442b626179b173
src/slave/flags.cpp ab8709861eb037e75dd2e91a097048ea6cd20c9c
src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05
src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e
src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e
src/tests/fetcher_cache_tests.cpp cbd44b98d19953d174fac977f509d4900a37481f
src/tests/fetcher_tests.cpp 361d918db183d31ef00e414e8b991846a9172be8
src/tests/isolator.hpp fd6aec74edf49153d31b559d56e8e06c15836f68
src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1
src/tests/main.cpp 970a8b06e1c04cb6545353c8d36f5707c153d49b
src/tests/mesos.hpp c00adb1d5665c86b18a468f41e7e658eebbb4959
src/tests/mesos.cpp d3a8bb70478993883f34804c8e2d7559d16c3538
src/tests/port_mapping_tests.cpp f8372df74cd71df37de4a2438069ef0ea8878512
src/tests/resources_tests.cpp b4a9bbf5dab0329b89da732d2b27c3ab0b118260
src/usage/main.cpp 86fd79628c29ba8ca9ef04ff00102aa254f10b03
Diff: https://reviews.apache.org/r/34886/diff/
Testing
-------
Thanks,
weitao zhou
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review85976
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34886]
All tests passed.
- Mesos ReviewBot
On June 1, 2015, 12:16 p.m., weitao zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34886/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 12:16 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2787
> https://issues.apache.org/jira/browse/MESOS-2787
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
> when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
> return the statistics yet now
>
>
> Diffs
> -----
>
> src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a
>
> Diff: https://reviews.apache.org/r/34886/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> weitao zhou
>
>
Re: Review Request 34886: MESOS-2787: Fixed the exception KeyError:
'mem_rss_bytes' when run command mesos-ps
Posted by weitao zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/
-----------------------------------------------------------
(Updated 六月 1, 2015, 12:16 p.m.)
Review request for mesos.
Bugs: MESOS-2787
https://issues.apache.org/jira/browse/MESOS-2787
Repository: mesos
Description
-------
The exception KeyError: 'mem_rss_bytes' or 'KeyError: cpus_system_time_secs' raised
when run command mesos ps --master=<> which is caused by some mesos slave nodes can't
return the statistics yet now
Diffs
-----
src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a
Diff: https://reviews.apache.org/r/34886/diff/
Testing
-------
Thanks,
weitao zhou