[GitHub] [nifi] mosermw commented on a diff in pull request #7281: NIFI-11580 set DistributedCacheClient to use daemon threads for clean shutdown

["mosermw (via GitHub)" <gi...@apache.org>]

mosermw commented on code in PR #7281:
URL: https://github.com/apache/nifi/pull/7281#discussion_r1204384367


##########
nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-services-bundle/nifi-distributed-cache-client-service/src/main/java/org/apache/nifi/distributed/cache/client/CacheClientChannelPoolFactory.java:
##########
@@ -70,7 +71,7 @@ public ChannelPool createChannelPool(final String hostname,
                                          final SSLContextService sslContextService,
                                          final VersionNegotiatorFactory factory) {
         final SSLContext sslContext = (sslContextService == null) ? null : sslContextService.createContext();
-        final EventLoopGroup group = new NioEventLoopGroup();
+        final EventLoopGroup group = new NioEventLoopGroup(new DefaultThreadFactory("DMCNioEventLoopGroup", true));

Review Comment:
   Great suggestion, so I borrowed the pattern from [EventCacheServer](https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-services-bundle/nifi-distributed-cache-server/src/main/java/org/apache/nifi/distributed/cache/server/EventCacheServer.java#L98).  Thread names now look like "NettyDistributedMapCacheClient[43cf63eb-0188-1000-365c-d44c52e3677e]-1-3@23872"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org