You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/28 09:40:16 UTC

[GitHub] [skywalking-kubernetes] kezhenxu94 commented on a diff in pull request #86: Fix hasSuffix replace hasPrefix

kezhenxu94 commented on code in PR #86:
URL: https://github.com/apache/skywalking-kubernetes/pull/86#discussion_r884109502


##########
chart/skywalking/templates/es-init.job.yaml:
##########
@@ -15,7 +15,7 @@
 
 # https://docs.sentry.io/server/installation/docker/#running-migrations
 
-{{- if hasPrefix "elasticsearch" .Values.oap.storageType }}

Review Comment:
   This was to match `elasticsearch` and `elasticsearch7`, we can modify it to equals since we merge ES versions but modifying yo suffix is wrong in any point of view. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org