You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Lai <ja...@jasonlai.net> on 2018/09/24 20:40:59 UTC
Re: Review Request 65811: Added Stout `path::normalize` function for
POSIX paths.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/
-----------------------------------------------------------
(Updated Sept. 24, 2018, 8:40 p.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Updated summary and description.
Summary (updated)
-----------------
Added Stout `path::normalize` function for POSIX paths.
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description (updated)
-------
Added `path::normalize` to normalize a given pathname and remove
redundant separators and up-level references.
This function follows the rules described in `path_resolution(7)`
for Linux. However, it only performs pure lexical processing without
touching the actual filesystem.
Diffs
-----
3rdparty/stout/include/stout/path.hpp ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/7/
Testing
-------
Thanks,
Jason Lai
Re: Review Request 65811: Added Stout `path::normalize` function for
POSIX paths.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review210638
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 7, 2018, 10:10 p.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65811/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2018, 10:10 p.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257 and MESOS-9009
> https://issues.apache.org/jira/browse/MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-9009
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `path::normalize` to normalize a given pathname and remove
> redundant separators and up-level references.
>
> This function follows the rules described in `path_resolution(7)`
> for Linux. However, it only performs pure lexical processing without
> touching the actual filesystem.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/path.hpp ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
>
>
> Diff: https://reviews.apache.org/r/65811/diff/9/
>
>
> Testing
> -------
>
> `make tests and make check` with https://reviews.apache.org/r/68832/
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65811: Added Stout `path::normalize` function for
POSIX paths.
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/
-----------------------------------------------------------
(Updated Nov. 7, 2018, 10:10 p.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Required for [MESOS-9009](https://issues.apache.org/jira/browse/MESOS-9009)
Bugs: MESOS-8257 and MESOS-9009
https://issues.apache.org/jira/browse/MESOS-8257
https://issues.apache.org/jira/browse/MESOS-9009
Repository: mesos
Description
-------
Added `path::normalize` to normalize a given pathname and remove
redundant separators and up-level references.
This function follows the rules described in `path_resolution(7)`
for Linux. However, it only performs pure lexical processing without
touching the actual filesystem.
Diffs
-----
3rdparty/stout/include/stout/path.hpp ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/9/
Testing
-------
`make tests and make check` with https://reviews.apache.org/r/68832/
Thanks,
Jason Lai
Re: Review Request 65811: Added Stout `path::normalize` function for
POSIX paths.
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/
-----------------------------------------------------------
(Updated Nov. 7, 2018, 9:22 p.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Rebased to master
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Added `path::normalize` to normalize a given pathname and remove
redundant separators and up-level references.
This function follows the rules described in `path_resolution(7)`
for Linux. However, it only performs pure lexical processing without
touching the actual filesystem.
Diffs (updated)
-----
3rdparty/stout/include/stout/path.hpp ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/9/
Changes: https://reviews.apache.org/r/65811/diff/8-9/
Testing
-------
`make tests and make check` with https://reviews.apache.org/r/68832/
Thanks,
Jason Lai
Re: Review Request 65811: Added Stout `path::normalize` function for
POSIX paths.
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/
-----------------------------------------------------------
(Updated Sept. 26, 2018, 11:59 p.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Added `path::normalize` to normalize a given pathname and remove
redundant separators and up-level references.
This function follows the rules described in `path_resolution(7)`
for Linux. However, it only performs pure lexical processing without
touching the actual filesystem.
Diffs
-----
3rdparty/stout/include/stout/path.hpp ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/8/
Testing (updated)
-------
`make tests and make check` with https://reviews.apache.org/r/68832/
Thanks,
Jason Lai
Re: Review Request 65811: Added Stout `path::normalize` function for
POSIX paths.
Posted by Eric Chung <ci...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review208977
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Chung
On Sept. 25, 2018, 12:08 a.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65811/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2018, 12:08 a.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `path::normalize` to normalize a given pathname and remove
> redundant separators and up-level references.
>
> This function follows the rules described in `path_resolution(7)`
> for Linux. However, it only performs pure lexical processing without
> touching the actual filesystem.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/path.hpp ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
>
>
> Diff: https://reviews.apache.org/r/65811/diff/8/
>
>
> Testing
> -------
>
> `make tests` with https://reviews.apache.org/r/68832/
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 65811: Added Stout `path::normalize` function for
POSIX paths.
Posted by Jason Lai <ja...@jasonlai.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/
-----------------------------------------------------------
(Updated Sept. 25, 2018, 12:08 a.m.)
Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
Changes
-------
Updated comment for failure on attempting to escape root and minor change.
Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257
Repository: mesos
Description
-------
Added `path::normalize` to normalize a given pathname and remove
redundant separators and up-level references.
This function follows the rules described in `path_resolution(7)`
for Linux. However, it only performs pure lexical processing without
touching the actual filesystem.
Diffs (updated)
-----
3rdparty/stout/include/stout/path.hpp ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
Diff: https://reviews.apache.org/r/65811/diff/8/
Changes: https://reviews.apache.org/r/65811/diff/7-8/
Testing (updated)
-------
`make tests` with https://reviews.apache.org/r/68832/
Thanks,
Jason Lai
Re: Review Request 65811: Added Stout `path::normalize` function for
POSIX paths.
Posted by Eric Chung <ci...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65811/#review208963
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Chung
On Sept. 24, 2018, 8:40 p.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65811/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2018, 8:40 p.m.)
>
>
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and Zhitao Li.
>
>
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `path::normalize` to normalize a given pathname and remove
> redundant separators and up-level references.
>
> This function follows the rules described in `path_resolution(7)`
> for Linux. However, it only performs pure lexical processing without
> touching the actual filesystem.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/path.hpp ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7
>
>
> Diff: https://reviews.apache.org/r/65811/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Lai
>
>