You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "zhoujinsong (via GitHub)" <gi...@apache.org> on 2024/04/16 12:33:46 UTC

[PR] Change package name for module mixed-format/spark [amoro]

zhoujinsong opened a new pull request, #2756:
URL: https://github.com/apache/amoro/pull/2756

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
     2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
   -->
   
   ## Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about its use case.
     2. If you fix a bug, you can clarify why it is a bug.
     3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
   -->
   
   Change package name to `org.apache.amoro` for mixed-format/spark modules.
   
   ## Brief change log
   <!--
   Clearly describe the changes made in modules, classes, methods, etc.
   -->
   
   - Change package name.
   - Change related configuration.
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] Run test locally before making a pull request
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (no)
   - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Change package name for module mixed-format/spark [amoro]

Posted by "zhongqishang (via GitHub)" <gi...@apache.org>.
zhongqishang commented on code in PR #2756:
URL: https://github.com/apache/amoro/pull/2756#discussion_r1568451895


##########
mixed-format/spark/v3.3/spark/src/main/scala/org/apache/amoro/spark/SupportSparkAdapter.scala:
##########
@@ -16,7 +16,9 @@
  * limitations under the License.
  */
 
-package com.netease.arctic.spark
+package org.apache.amoro.spark
+
+import org.apache.amoro.spark.{SparkAdapter, SparkAdapterLoader}

Review Comment:
   Unused import statement.



##########
mixed-format/spark/v3.2/spark/src/test/resources/log4j2.properties:
##########
@@ -17,11 +17,11 @@
 #
 
 log4j.rootLogger=INFO
-log4j.logger.com.netease.arctic=INFO
-log4j.logger.com.netease.arctic.spark=DEBUG
+log4j.logger.org.apache.amoro=INFO
+log4j.logger.org.apache.amoro.spark=DEBUG
 log4j.logger.org.apache.thrift.server=WARN
 log4j.logger.org.sparkproject.jetty.server=WARN
-log4j.logger.com.netease.arctic.ams.api.client=WARN
+log4j.logger.org.apache.amoro.client=WARN

Review Comment:
   ```suggestion
   log4j.logger.com.netease.arctic.client=WARN
   ```



##########
mixed-format/spark/v3.3/spark/src/test/resources/log4j2.properties:
##########
@@ -17,11 +17,11 @@
 #
 
 log4j.rootLogger=INFO
-log4j.logger.com.netease.arctic=INFO
-log4j.logger.com.netease.arctic.spark=DEBUG
+log4j.logger.org.apache.amoro=INFO
+log4j.logger.org.apache.amoro.spark=DEBUG
 log4j.logger.org.apache.thrift.server=WARN
 log4j.logger.org.sparkproject.jetty.server=WARN
-log4j.logger.com.netease.arctic.ams.api.client=WARN
+log4j.logger.org.apache.amoro.client=WARN

Review Comment:
   ```suggestion
   log4j.logger.com.netease.arctic.client=WARN
   ```



##########
mixed-format/spark/v3.2/spark/src/main/scala/org/apache/amoro/spark/SupportSparkAdapter.scala:
##########
@@ -16,7 +16,9 @@
  * limitations under the License.
  */
 
-package com.netease.arctic.spark
+package org.apache.amoro.spark
+
+import org.apache.amoro.spark.{SparkAdapter, SparkAdapterLoader}

Review Comment:
   Unused import statement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Change package name for module mixed-format/spark [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #2756:
URL: https://github.com/apache/amoro/pull/2756#issuecomment-2060726505

   Can you help to review again? @zhongqishang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Change package name for module mixed-format/spark [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #2756:
URL: https://github.com/apache/amoro/pull/2756#issuecomment-2060692898

   > @zhoujinsong `.tokens` and `.interp` does not exist before, it is necessary to add its?
   
   Thanks for the detailed review. They should not be added. I will drop them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Change package name for module mixed-format/spark [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #2756:
URL: https://github.com/apache/amoro/pull/2756#discussion_r1568475952


##########
mixed-format/spark/v3.3/spark/src/main/scala/org/apache/amoro/spark/SupportSparkAdapter.scala:
##########
@@ -16,7 +16,9 @@
  * limitations under the License.
  */
 
-package com.netease.arctic.spark
+package org.apache.amoro.spark
+
+import org.apache.amoro.spark.{SparkAdapter, SparkAdapterLoader}

Review Comment:
   Removed.



##########
mixed-format/spark/v3.2/spark/src/main/scala/org/apache/amoro/spark/SupportSparkAdapter.scala:
##########
@@ -16,7 +16,9 @@
  * limitations under the License.
  */
 
-package com.netease.arctic.spark
+package org.apache.amoro.spark
+
+import org.apache.amoro.spark.{SparkAdapter, SparkAdapterLoader}

Review Comment:
   Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Change package name for module mixed-format/spark [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #2756:
URL: https://github.com/apache/amoro/pull/2756


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org