You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/30 22:16:00 UTC

[jira] [Commented] (DRILL-6589) Push transitive closure generated predicates past aggregates

    [ https://issues.apache.org/jira/browse/DRILL-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562591#comment-16562591 ] 

ASF GitHub Bot commented on DRILL-6589:
---------------------------------------

ilooner commented on issue #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects
URL: https://github.com/apache/drill/pull/1372#issuecomment-409029716
 
 
   @gparai It looks like this change has compilation issues with the latest master. Could you rebase onto the latest and resolve the errors? Below is what I see when building locally on my laptop.
   
   ```
   [ERROR] COMPILATION ERROR : 
   [INFO] -------------------------------------------------------------
   [ERROR] /Users/timothyfarkas/dev/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/image/ImageFormatPlugin.java:[71,27] error: cannot find symbol
   [ERROR]   symbol:   variable IMAGE_SUB_SCAN_VALUE
     location: class CoreOperatorType
   /Users/timothyfarkas/dev/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileFormatPlugin.java:[80,27] error: cannot find symbol
   [ERROR]   symbol:   variable SEQUENCE_SUB_SCAN_VALUE
     location: class CoreOperatorType
   /Users/timothyfarkas/dev/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/httpd/HttpdLogFormatPlugin.java:[270,27] error: cannot find symbol
   [ERROR]   symbol:   variable HTPPD_LOG_SUB_SCAN_VALUE
     location: class CoreOperatorType
   /Users/timothyfarkas/dev/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java:[147,28] error: cannot find symbol
   [INFO] 4 errors 
   [INFO] -------------------------------------------------------------
   [INFO] ------------------------------------------------------------------------
   [INFO] Reactor Summary:
   [INFO] 
   [INFO] Apache Drill Root POM .............................. SUCCESS [ 31.271 s]
   [INFO] tools/Parent Pom ................................... SUCCESS [ 13.950 s]
   [INFO] tools/freemarker codegen tooling ................... SUCCESS [ 20.129 s]
   [INFO] Drill Protocol ..................................... SUCCESS [ 24.726 s]
   [INFO] Common (Logical Plan, Base expressions) ............ SUCCESS [ 24.689 s]
   [INFO] Logical Plan, Base expressions ..................... SUCCESS [ 22.271 s]
   [INFO] exec/Parent Pom .................................... SUCCESS [  9.611 s]
   [INFO] exec/memory/Parent Pom ............................. SUCCESS [ 14.463 s]
   [INFO] exec/memory/base ................................... SUCCESS [ 20.118 s]
   [INFO] exec/rpc ........................................... SUCCESS [ 35.568 s]
   [INFO] exec/Vectors ....................................... SUCCESS [01:24 min]
   [INFO] contrib/Parent Pom ................................. SUCCESS [ 18.150 s]
   [INFO] contrib/data/Parent Pom ............................ SUCCESS [ 19.916 s]
   [INFO] contrib/data/tpch-sample-data ...................... SUCCESS [ 19.568 s]
   [INFO] exec/Java Execution Engine ......................... FAILURE [01:03 min]
   [INFO] exec/JDBC Driver using dependencies ................ SKIPPED
   [INFO] JDBC JAR with all dependencies ..................... SKIPPED
   [INFO] Drill-on-YARN ...................................... SKIPPED
   [INFO] contrib/kudu-storage-plugin ........................ SKIPPED
   [INFO] contrib/opentsdb-storage-plugin .................... SKIPPED
   [INFO] contrib/mongo-storage-plugin ....................... SKIPPED
   [INFO] contrib/hbase-storage-plugin ....................... SKIPPED
   [INFO] contrib/jdbc-storage-plugin ........................ SKIPPED
   [INFO] contrib/hive-storage-plugin/Parent Pom ............. SUCCESS [ 12.652 s]
   [INFO] contrib/hive-storage-plugin/hive-exec-shaded ....... SUCCESS [01:01 min]
   [INFO] contrib/mapr-format-plugin ......................... SKIPPED
   [INFO] contrib/hive-storage-plugin/core ................... SKIPPED
   [INFO] contrib/drill-gis-plugin ........................... SKIPPED
   [INFO] contrib/kafka-storage-plugin ....................... SKIPPED
   [INFO] Packaging and Distribution Assembly ................ SKIPPED
   [INFO] contrib/sqlline .................................... SKIPPED
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time: 05:28 min (Wall Clock)
   [INFO] Finished at: 2018-07-30T15:11:22-07:00
   [INFO] Final Memory: 146M/1651M
   [INFO] ------------------------------------------------------------------------
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project drill-java-exec: Compilation failure: Compilation failure: 
   [ERROR] /Users/timothyfarkas/dev/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/image/ImageFormatPlugin.java:[71,27] error: cannot find symbol
   [ERROR]   symbol:   variable IMAGE_SUB_SCAN_VALUE
   [ERROR]   location: class CoreOperatorType
   [ERROR] /Users/timothyfarkas/dev/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/sequencefile/SequenceFileFormatPlugin.java:[80,27] error: cannot find symbol
   [ERROR]   symbol:   variable SEQUENCE_SUB_SCAN_VALUE
   [ERROR]   location: class CoreOperatorType
   [ERROR] /Users/timothyfarkas/dev/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/httpd/HttpdLogFormatPlugin.java:[270,27] error: cannot find symbol
   [ERROR]   symbol:   variable HTPPD_LOG_SUB_SCAN_VALUE
   [ERROR]   location: class CoreOperatorType
   [ERROR] /Users/timothyfarkas/dev/drill/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONFormatPlugin.java:[147,28] error: cannot find symbol
   [ERROR] -> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please read the following articles:
   [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
   [ERROR] 
   [ERROR] After correcting the problems, you can resume the build with the command
   [ERROR]   mvn <goals> -rf :drill-java-exec
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Push transitive closure generated predicates past aggregates
> ------------------------------------------------------------
>
>                 Key: DRILL-6589
>                 URL: https://issues.apache.org/jira/browse/DRILL-6589
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.13.0
>            Reporter: Gautam Kumar Parai
>            Assignee: Gautam Kumar Parai
>            Priority: Major
>              Labels: ready-to-commit
>             Fix For: 1.15.0
>
>
> Here is a sample query that may benefit from this optimization:
> SELECT * FROM T1 WHERE a1 = 5 AND a1 IN (SELECT a2 FROM T2); 
> Here the transitive predicate a2 = 5 would be pushed past the aggregate due to this optimization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)