You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/23 19:22:03 UTC

[GitHub] [iceberg] rdblue commented on pull request #1636: WIP - Draft to remove NarrowingCompoundAssignment warnings

rdblue commented on pull request #1636:
URL: https://github.com/apache/iceberg/pull/1636#issuecomment-715535478


   Looks correct to me. I'd just remove most of the comments because all you're doing is setting the value from the source that is already an `int`.
   
   FYI @shardulm94.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org