[jira] [Commented] (TREQ-11) Support for Mustache

["Nicolas Le Bas (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TREQ-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210447#comment-13210447 ] 

Nicolas Le Bas commented on TREQ-11:
------------------------------------

I've had a look at the code and I have a couple of questions about it. No criticism meant: I realize the request API is not sufficiently documented yet, and I appreciate the effort involved in contributing in a pre-beta version.

- why a new interface to locate Mustache templates? If ApplicationContext.getResource(...) doesn't deliver, perhaps we should improve on that instead of creating a new interface.

- relying on java.io.File / FileFilter seems dangerous to me, it has cross-platform issues. If the intent is to locate a file on the classpath (as expressed in the test case), then the file separator should always be "/". Using File would accept "\" as a separator on Windows, which would be incorrect.

- Do we need MustacheRequest at all? I don't see it instantiated anywhere.

                
> Support for Mustache
> --------------------
>
>                 Key: TREQ-11
>                 URL: https://issues.apache.org/jira/browse/TREQ-11
>             Project: Tiles Request
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Nicolas Le Bas
>              Labels: patch
>
> Morten Lied Johansen has filed a pull request on github: https://github.com/apache/tiles/pull/1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira