You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/30 08:51:18 UTC
[GitHub] [shardingsphere] zhaoguhong opened a new pull request, #18067: Fix encrypt examples EncryptColumnRuleConfiguration constructor
zhaoguhong opened a new pull request, #18067:
URL: https://github.com/apache/shardingsphere/pull/18067
Fix encrypt examples EncryptColumnRuleConfiguration constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaoguhong commented on a diff in pull request #18067: Fix encrypt examples EncryptColumnRuleConfiguration constructor
Posted by GitBox <gi...@apache.org>.
zhaoguhong commented on code in PR #18067:
URL: https://github.com/apache/shardingsphere/pull/18067#discussion_r884648793
##########
examples/shardingsphere-example-generator/src/main/resources/template/jdbc/java/TestQueryAssistedShardingEncryptAlgorithm.ftl:
##########
@@ -50,4 +50,9 @@ public final class TestQueryAssistedShardingEncryptAlgorithm implements QueryAss
public String getType() {
return "assistedTest";
}
+
+ @Override
+ public void init(Properties props) {
Review Comment:
ok，I see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on pull request #18067: Fix encrypt examples EncryptColumnRuleConfiguration constructor
Posted by GitBox <gi...@apache.org>.
totalo commented on PR #18067:
URL: https://github.com/apache/shardingsphere/pull/18067#issuecomment-1141070842
Good job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on a diff in pull request #18067: Fix encrypt examples EncryptColumnRuleConfiguration constructor
Posted by GitBox <gi...@apache.org>.
totalo commented on code in PR #18067:
URL: https://github.com/apache/shardingsphere/pull/18067#discussion_r884627940
##########
examples/shardingsphere-example-generator/src/main/resources/template/jdbc/java/TestQueryAssistedShardingEncryptAlgorithm.ftl:
##########
@@ -50,4 +50,9 @@ public final class TestQueryAssistedShardingEncryptAlgorithm implements QueryAss
public String getType() {
return "assistedTest";
}
+
+ @Override
+ public void init(Properties props) {
Review Comment:
Thanks for your contribution, but this init method I think needs to initialize props, you can refer to the rest of the TestQueryAssistedShardingEncryptAlgorithm file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18067: Fix encrypt examples EncryptColumnRuleConfiguration constructor
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18067:
URL: https://github.com/apache/shardingsphere/pull/18067#issuecomment-1140924087
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18067](https://codecov.io/gh/apache/shardingsphere/pull/18067?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (285bace) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b2fad36a125897fc3af1a774a0e1390c9a5db2a1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2fad36) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #18067 +/- ##
=========================================
Coverage 58.94% 58.94%
Complexity 2153 2153
=========================================
Files 3671 3671
Lines 54156 54156
Branches 9196 9196
=========================================
Hits 31922 31922
Misses 19522 19522
Partials 2712 2712
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18067?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18067?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b2fad36...285bace](https://codecov.io/gh/apache/shardingsphere/pull/18067?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo merged pull request #18067: Fix encrypt examples EncryptColumnRuleConfiguration constructor
Posted by GitBox <gi...@apache.org>.
totalo merged PR #18067:
URL: https://github.com/apache/shardingsphere/pull/18067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org