You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/07/27 17:11:09 UTC

[GitHub] [systemds] phaniarnab commented on pull request #1650: [SYSTEMDS-3390] Replace slicing for countDistinctApprox() row/col aggregation with direct ops

phaniarnab commented on PR #1650:
URL: https://github.com/apache/systemds/pull/1650#issuecomment-1197059845

   Thanks for the PR @BACtaki. I had an initial look at the code changes today. Before I get into detailed comments, I'd like to clarify a few things.
   - Are the optimizations only improve the naive cases where the input dimension is less than 1024 for the given direction (row/col)? 
   - I see that you are now iterating the dense and sparse inputs in a more cache-conscious manner (reducing CPU cache misses). Are there any other optimizations you are employing (e.g. reducing the number of intermediates)?
   
   Sorry for the delay. I will add my comments and suggestions tomorrow. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org