You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2026/07/16 07:59:19 UTC
[PR] kie-issues#2365: Add drools-lsp to kie-tools [incubator-kie-tools]
tkobayas opened a new pull request, #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665
Migrate the drools-lsp project (DRL Language Server Protocol + VS Code extension) from kiegroup/drools-lsp into the kie-tools monorepo.
New packages:
- packages/drools-lsp/ — Java multi-module Maven project (drools-parser, drools-completion, drools-lsp-server) producing an LSP server uber-JAR
- packages/drl-vscode-extension/ — VS Code extension that launches the DRL Language Server for .drl file editing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3608693425
##########
packages/drl-vscode-extension/README.md:
##########
@@ -0,0 +1,29 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## DRL Editor
+
+Edit DRL (Drools Rule Language) files with language support provided by the [DRL Language Server](../drools-lsp).
+
+## Features
+
+- Syntax highlighting for `.drl` files.
+- LSP features backed by a local JVM running the DRL Language Server: completion, diagnostics, hover, go-to-definition, references, document symbols, code lenses, folding ranges, inlay hints, and rename.
+
+## Requirements
Review Comment:
other requirements (e.g. maven) are no longer listed - add them, or refer to a parent-repo readme?
##########
packages/drl-vscode-extension/package.json:
##########
@@ -0,0 +1,196 @@
+{
+ "name": "drl-vscode-extension",
+ "version": "0.0.0",
+ "description": "Edit DRL (Drools Rule Language) files",
+ "license": "Apache-2.0",
+ "publisher": "kie-group",
+ "keywords": [],
+ "homepage": "https://github.com/apache/incubator-kie-tools",
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/incubator-kie-tools.git"
+ },
+ "bugs": {
+ "url": "https://github.com/apache/incubator-kie-tools/issues"
+ },
+ "main": "dist/extension/extension.js",
+ "scripts": {
+ "build:dev": "rimraf dist && webpack --env dev",
+ "build:prod": "rimraf dist && webpack && pnpm pack:prod",
+ "compile": "webpack",
+ "lint": "run-script-if --bool \"$(build-env linters.run)\" --then \"kie-tools--eslint ./src\"",
+ "pack:prod": "vsce package --githubBranch main --no-dependencies -o ./dist/drl_vscode_extension_$npm_package_version.vsix",
+ "pretest": "pnpm build:dev && mvn -f src/testFixture/pom.xml -ntp compile && tsc -p tsconfig.test.json",
+ "test": "node ./out-test/test/runTest.js",
+ "watch": "export WEBPACK__sourceMaps=true; WEBPACK__minimize=false; webpack --env dev"
+ },
+ "dependencies": {
+ "vscode-languageclient": "^9.0.1"
+ },
+ "devDependencies": {
+ "@kie-tools-core/webpack-base": "workspace:*",
+ "@kie-tools-scripts/build-env": "workspace:*",
+ "@kie-tools/drools-lsp": "workspace:*",
+ "@kie-tools/eslint": "workspace:*",
+ "@kie-tools/root-env": "workspace:*",
+ "@kie-tools/tsconfig": "workspace:*",
+ "@types/mocha": "^10.0.7",
+ "@types/vscode": "1.67.0",
Review Comment:
engines.vscode is `^1.103.0` below - if the minimum is 103 the API could be as well? I haven't checked compatibility yet but wouldn't expect any breaking changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3619490194
##########
pnpm-lock.yaml:
##########
@@ -17150,8 +17237,8 @@ packages:
fast-text-encoding@1.0.3:
resolution: {integrity: sha512-dtm4QZH9nZtcDt8qJiOH9fcQd1NAgi+K1O2DbE6GG1PPCK/BWfOH3idCTRQ4ImXRUOyopDEgDEnVEE7Y/2Wrig==}
- fast-uri@3.1.3:
- resolution: {integrity: sha512-i70LwGWUduXqzicKXWshooq+sWL1K3WUU5rKZNG/0i3a1OSoX3HqhH5WbWwTmqWfor4urUakGPiRQcleRZTwOg==}
+ fast-uri@3.1.2:
+ resolution: {integrity: sha512-rVjf7ArG3LTk+FS6Yw81V1DLuZl1bRbNrev6Tmd/9RaroeeRRJhAt7jg/6YFxbvAQXUCavSoZhPPj6oOx+5KjQ==}
Review Comment:
`fast-uri` was updated to `3.1.3` in https://github.com/apache/incubator-kie-tools/pull/3667 . But running `pnpm bootstrap` reverts it back to `3.1.2`.
I guess the 3667 PR should have pinned the version by `pnpm-workspace.yaml` or `package.json`? I'm not familiar with this repo, so sorry if it's missing a point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "Rikkola (via GitHub)" <gi...@apache.org>.
Rikkola commented on PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#issuecomment-5031790655
No worries, I just remembered we have some automation around this, but not sure how it triggers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3611347266
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
@tiagobento it was the initial download of all the resources to the local maven repo.
However looking at the timestamps of the resources everything was installed within 7 minutes, so maybe something else was wrong on my end (I had to make a couple of minor adjustments to some build scripts for a windows build).
I have now ran both build:dev and build:prod and installed the extension from the installer for a local smoke test and everything looks good. All functionalities from before the port are available.
Good to see this tool coming to its proper home!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "Rikkola (via GitHub)" <gi...@apache.org>.
Rikkola commented on PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#issuecomment-5031545522
All looks good to me too. I believer our other plugins get pushlished when we do releases. Does anyone know it this is now included and published too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#issuecomment-5030243315
@yesamer @Rikkola Could you please review this PR to get 2 approvals? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3609143647
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
The `drools-and-kogito` package here in `kie-tools` should actually build pretty fast! It shouldn't take hours... Plus it should be cached locally if the commit ref hashes are the same.
What part of what you're doing is taking so long?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3609114374
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
@tiagobento understood: I am aware of the restructuring - I just wanted to conduct a functional test against the prior repo and the env setup is taking hours so far. So just wanted to mention it. Maybe around the 10.3.0 release this could be re-examined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas merged PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3608746120
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
We're in the middle of an upstream restructuring effort to consolidate Drools, OptaPlanner, and Kogito repositories.
In the near future, we'll be able to explore more granular builds of upstream dependencies, with packages on `kie-tools` potentially being able to declare individual module trees, instead of dependending on the current all-or-nothing `drools-and-kogito` package.
For now, we have to live with this overhead for a little while longer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3608690177
##########
packages/drools-lsp/pom.xml:
##########
@@ -0,0 +1,81 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"
+>
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>./node_modules/@kie-tools/maven-base/pom.xml</relativePath>
+ </parent>
+
+ <groupId>org.kie.tools</groupId>
+ <artifactId>drools-lsp</artifactId>
+ <packaging>pom</packaging>
+
+ <properties>
+ <version.org.antlr4>4.10.1</version.org.antlr4>
+ <version.org.eclipse.lsp4j>0.19.0</version.org.eclipse.lsp4j>
+ <version.antlr4-c3>1.1</version.antlr4-c3>
+ <version.org.junit>5.9.1</version.org.junit>
+ <version.junit.platform>1.9.1</version.junit.platform>
+ <version.org.assertj>3.23.1</version.org.assertj>
+ <version.ch.qos.logback>1.5.16</version.ch.qos.logback>
Review Comment:
@tkobayas it appears that the ANTLR version may now be unpinned. From Claude:
ANTLR toolchain version change (the item most worth confirming) — module POMs dropped their pinned versions; maven-base/pom.xml.template now sets the antlr4-maven-plugin to 4.13.2 (was 4.10.1 in the source), while antlr4-runtime/antlr4 are left unmanaged in maven-base and resolve transitively through the imported kogito-apps-bom. The source project pinned the entire ANTLR stack to 4.10.1. Since drools-parser underlies all completion/lint/hover behavior, and ANTLR wants the generator tool and runtime aligned, this is a real (if low-probability) behavior risk: the parser is now generated by a newer tool against a BOM-dictated runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3594211575
##########
packages/drools-lsp/pom.xml:
##########
@@ -0,0 +1,81 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"
+>
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>./node_modules/@kie-tools/maven-base/pom.xml</relativePath>
+ </parent>
+
+ <groupId>org.kie.tools</groupId>
+ <artifactId>drools-lsp</artifactId>
+ <packaging>pom</packaging>
+
+ <properties>
+ <version.org.antlr4>4.10.1</version.org.antlr4>
+ <version.org.eclipse.lsp4j>0.19.0</version.org.eclipse.lsp4j>
+ <version.antlr4-c3>1.1</version.antlr4-c3>
+ <version.org.junit>5.9.1</version.org.junit>
+ <version.junit.platform>1.9.1</version.junit.platform>
+ <version.org.assertj>3.23.1</version.org.assertj>
+ <version.ch.qos.logback>1.5.16</version.ch.qos.logback>
Review Comment:
@tkobayas Consider that kie-tools-maven-base inherits the kie-parent bom, where most of those are already declared. Do we really need them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#issuecomment-5031593391
@Rikkola Release/Publish is not included in this PR. I filed a follow-up issue https://github.com/apache/incubator-kie-tools/issues/3672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3608697384
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
building downloads the entire drools-and-kogito dependency chain, which is a lot of overhead not necessary for this tool and a significant hurdle for potential contributors. It is not introduced in this PR but inherited from `maven-base` in `kogito-apps-bom`, but maybe worth a followup rescoping, if not here?
I haven't tried it yet, but claude recommends adding an opt-out to the parent KIE BOM for minimal tool builds
**Surgical, near-zero blast radius: gate the KIE BOM behind a default-on, opt-out profile in maven-base, and have drools-lsp opt out + pin ANTLR.**
In `maven-base/pom.xml.template`, move the BOM import into a profile that's active unless a property says otherwise:
``` xml
<profiles>
<profile>
<id>kie-runtime-bom</id>
<activation>
<property><name>!kieRuntimeBom.skip</name></property> <!-- active by default -->
</activation>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.kie.kogito</groupId>
<artifactId>kogito-apps-bom</artifactId>
<version>${version.org.kie.kogito}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
</profile>
</profiles>
```
Then in drools-lsp/pom.xml, opt out and pin the one version it was getting from the BOM:
``` xml
<properties>
<kieRuntimeBom.skip>true</kieRuntimeBom.skip>
<version.org.antlr4>4.13.2</version.org.antlr4>
</properties>
<dependencyManagement>
<dependencies>
<dependency><groupId>org.antlr</groupId><artifactId>antlr4-runtime</artifactId><version>${version.org.antlr4}</version></dependency>
<dependency><groupId>org.antlr</groupId><artifactId>antlr4</artifactId><version>${version.org.antlr4}</version></dependency>
</dependencies>
</dependencyManagement>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3608697384
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
building downloads the entire drools-and-kogito dependency chain, which is a lot of overhead not necessary for this tool and a significant hurdle for potential contributors. It is not introduced in this PR but inherited from `maven-base` in `kogito-apps-bom`, but maybe worth a followup rescoping, if not here?
I tried a couple of methods but the only one I can get to work rn is cutting the drools-lsp/pom.xml off from the other projects in the repo (and `maven-base`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3619459598
##########
packages/drl-vscode-extension/README.md:
##########
@@ -0,0 +1,29 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## DRL Editor
+
+Edit DRL (Drools Rule Language) files with language support provided by the [DRL Language Server](../drools-lsp).
+
+## Features
+
+- Syntax highlighting for `.drl` files.
+- LSP features backed by a local JVM running the DRL Language Server: completion, diagnostics, hover, go-to-definition, references, document symbols, code lenses, folding ranges, inlay hints, and rename.
+
+## Requirements
Review Comment:
@drccrd Thanks, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3619060553
##########
packages/drl-vscode-extension/package.json:
##########
@@ -0,0 +1,196 @@
+{
+ "name": "drl-vscode-extension",
+ "version": "0.0.0",
+ "description": "Edit DRL (Drools Rule Language) files",
+ "license": "Apache-2.0",
+ "publisher": "kie-group",
+ "keywords": [],
+ "homepage": "https://github.com/apache/incubator-kie-tools",
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/incubator-kie-tools.git"
+ },
+ "bugs": {
+ "url": "https://github.com/apache/incubator-kie-tools/issues"
+ },
+ "main": "dist/extension/extension.js",
+ "scripts": {
+ "build:dev": "rimraf dist && webpack --env dev",
+ "build:prod": "rimraf dist && webpack && pnpm pack:prod",
+ "compile": "webpack",
+ "lint": "run-script-if --bool \"$(build-env linters.run)\" --then \"kie-tools--eslint ./src\"",
+ "pack:prod": "vsce package --githubBranch main --no-dependencies -o ./dist/drl_vscode_extension_$npm_package_version.vsix",
+ "pretest": "pnpm build:dev && mvn -f src/testFixture/pom.xml -ntp compile && tsc -p tsconfig.test.json",
+ "test": "node ./out-test/test/runTest.js",
+ "watch": "export WEBPACK__sourceMaps=true; WEBPACK__minimize=false; webpack --env dev"
+ },
+ "dependencies": {
+ "vscode-languageclient": "^9.0.1"
+ },
+ "devDependencies": {
+ "@kie-tools-core/webpack-base": "workspace:*",
+ "@kie-tools-scripts/build-env": "workspace:*",
+ "@kie-tools/drools-lsp": "workspace:*",
+ "@kie-tools/eslint": "workspace:*",
+ "@kie-tools/root-env": "workspace:*",
+ "@kie-tools/tsconfig": "workspace:*",
+ "@types/mocha": "^10.0.7",
+ "@types/vscode": "1.67.0",
Review Comment:
`"@types/vscode": "1.67.0",` is required to satisfy the syncpack version check. In other words, `1.67.0` is required in this incubator-kie-tools repo for now.
As vscode-languageclient 9 requires vscode 1.82+, we had set `engines.vscode` to `^1.103.0`, This may look inconsistent, but it actually works.
If we ever need to use APIs introduced after vscode 1.67, we can discuss updating `@types/vscode` with the kie-tools team.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3600627947
##########
packages/drools-lsp/pom.xml:
##########
@@ -0,0 +1,81 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+<project
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"
+>
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.kie</groupId>
+ <artifactId>kie-tools-maven-base</artifactId>
+ <version>${revision}</version>
+ <relativePath>./node_modules/@kie-tools/maven-base/pom.xml</relativePath>
+ </parent>
+
+ <groupId>org.kie.tools</groupId>
+ <artifactId>drools-lsp</artifactId>
+ <packaging>pom</packaging>
+
+ <properties>
+ <version.org.antlr4>4.10.1</version.org.antlr4>
+ <version.org.eclipse.lsp4j>0.19.0</version.org.eclipse.lsp4j>
+ <version.antlr4-c3>1.1</version.antlr4-c3>
+ <version.org.junit>5.9.1</version.org.junit>
+ <version.junit.platform>1.9.1</version.junit.platform>
+ <version.org.assertj>3.23.1</version.org.assertj>
+ <version.ch.qos.logback>1.5.16</version.ch.qos.logback>
Review Comment:
@yesamer Thank you for the point. Fixed and added to kie-tools-maven-base if not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3609114374
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
@tiagobento understood thank you: I am aware of the current restructuring efforts - I just wanted to conduct a functional test against the prior repo and the env setup is taking hours so far. So just wanted to mention it. Maybe around the 10.3.0 release this could be re-examined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3609114374
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
@tiagobento understood thank you: I am aware of the restructuring - I just wanted to conduct a functional test against the prior repo and the env setup is taking hours so far. So just wanted to mention it. Maybe around the 10.3.0 release this could be re-examined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3608697384
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
building downloads the entire drools-and-kogito dependency chain, which is a lot of overhead not necessary for this tool and a significant hurdle for potential contributors. It is not introduced in this PR but inherited from `maven-base` in `kogito-apps-bom`, but maybe worth a followup rescoping, if not here?
I haven't tried it yet, but claude recommends adding an opt-out to the parent KIE BOM for minimal tool builds
Surgical, near-zero blast radius: gate the KIE BOM behind a default-on, opt-out profile in maven-base, and have drools-lsp opt out + pin ANTLR.
In maven-base/pom.xml.template, move the BOM import into a profile that's active unless a property says otherwise:
<profiles>
<profile>
<id>kie-runtime-bom</id>
<activation>
<property><name>!kieRuntimeBom.skip</name></property> <!-- active by default -->
</activation>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.kie.kogito</groupId>
<artifactId>kogito-apps-bom</artifactId>
<version>${version.org.kie.kogito}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
</profile>
</profiles>
Then in drools-lsp/pom.xml, opt out and pin the one version it was getting from the BOM:
<properties>
<kieRuntimeBom.skip>true</kieRuntimeBom.skip>
<version.org.antlr4>4.13.2</version.org.antlr4>
</properties>
<dependencyManagement>
<dependencies>
<dependency><groupId>org.antlr</groupId><artifactId>antlr4-runtime</artifactId><version>${version.org.antlr4}</version></dependency>
<dependency><groupId>org.antlr</groupId><artifactId>antlr4</artifactId><version>${version.org.antlr4}</version></dependency>
</dependencies>
</dependencyManagement>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#2365: [DRL Editor] Add drools-lsp to kie-tools [incubator-kie-tools]
Posted by "drccrd (via GitHub)" <gi...@apache.org>.
drccrd commented on code in PR #3665:
URL: https://github.com/apache/incubator-kie-tools/pull/3665#discussion_r3608697384
##########
packages/drl-vscode-extension/DEV.md:
##########
@@ -0,0 +1,36 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+## Build
+
+This package depends on the server uber-JAR produced by `@kie-tools/drools-lsp`, so build it through the workspace filter that includes dependencies:
+
+```sh
+pnpm -F drl-vscode-extension... build:dev
Review Comment:
building downloads the entire drools-and-kogito dependency chain, which is a lot of overhead not necessary for this tool and a significant hurdle for potential contributors. It is not introduced in this PR but inherited from `maven-base` in `kogito-apps-bom`, but maybe worth a followup rescoping, if not here?
I tried a couple of methods but the only one I can get to work rn is cutting the drools-lsp/pom.xml off from the other projects in the repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org