You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Massimo Lusetti (JIRA)" <ji...@apache.org> on 2009/02/06 11:11:59 UTC
[jira] Created: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Small typo in javadoc comments for Cookies service.
---------------------------------------------------
Key: TAP5-500
URL: https://issues.apache.org/jira/browse/TAP5-500
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.18, 5.1.0.0, 5.1, 5.0.19
Reporter: Massimo Lusetti
Priority: Trivial
Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671080#action_12671080 ]
Massimo Lusetti commented on TAP5-500:
--------------------------------------
Strange complaints, anyway here is the diff.
Index: tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java
===================================================================
--- tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java (revision 741470)
+++ tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java (working copy)
@@ -52,17 +52,17 @@
void writeCookieValue(String name, String value, String path);
/**
- * As with {@link #writeCookieValue(String, String)} but an explicit path may be set.
+ * As with {@link #writeCookieValue(String, String)} but an explicit domain may be set.
*/
void writeDomainCookieValue(String name, String value, String domain);
/**
- * As with {@link #writeCookieValue(String, String)} but an explicit path may be set.
+ * As with {@link #writeCookieValue(String, String)} but an explicit domain and maximum age may be set.
*/
void writeDomainCookieValue(String name, String value, String domain, int maxAge);
/**
- * As with {@link #writeCookieValue(String, String, String)} but an explicit domain may be set.
+ * As with {@link #writeCookieValue(String, String, String)} but an explicit domain and path may be set.
*/
void writeCookieValue(String name, String value, String path, String domain);
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Priority: Trivial
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Ulrich Stärk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671078#action_12671078 ]
Ulrich Stärk commented on TAP5-500:
-----------------------------------
Maybe you should just tell the devs what the typo is. I believe it's faster to fix it manually than downloading and applying your patch.
Uli
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Priority: Trivial
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-500.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.1.0.4
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Trivial
> Fix For: 5.1.0.4
>
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Ulrich Stärk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671078#action_12671078 ]
Ulrich Stärk commented on TAP5-500:
-----------------------------------
Maybe you should just tell the devs what the typo is. I believe it's faster to fix it manually than downloading and applying your patch.
Uli
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Priority: Trivial
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-500:
-----------------------------------------
Assignee: Howard M. Lewis Ship
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Trivial
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti updated TAP5-500:
---------------------------------
Attachment: patch
Very simple patch
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Priority: Trivial
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671080#action_12671080 ]
Massimo Lusetti commented on TAP5-500:
--------------------------------------
Strange complaints, anyway here is the diff.
Index: tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java
===================================================================
--- tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java (revision 741470)
+++ tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java (working copy)
@@ -52,17 +52,17 @@
void writeCookieValue(String name, String value, String path);
/**
- * As with {@link #writeCookieValue(String, String)} but an explicit path may be set.
+ * As with {@link #writeCookieValue(String, String)} but an explicit domain may be set.
*/
void writeDomainCookieValue(String name, String value, String domain);
/**
- * As with {@link #writeCookieValue(String, String)} but an explicit path may be set.
+ * As with {@link #writeCookieValue(String, String)} but an explicit domain and maximum age may be set.
*/
void writeDomainCookieValue(String name, String value, String domain, int maxAge);
/**
- * As with {@link #writeCookieValue(String, String, String)} but an explicit domain may be set.
+ * As with {@link #writeCookieValue(String, String, String)} but an explicit domain and path may be set.
*/
void writeCookieValue(String name, String value, String path, String domain);
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Priority: Trivial
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-500.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.1.0.4
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Trivial
> Fix For: 5.1.0.4
>
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-500:
-----------------------------------------
Assignee: Howard M. Lewis Ship
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Assignee: Howard M. Lewis Ship
> Priority: Trivial
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-500) Small typo in javadoc comments for
Cookies service.
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Massimo Lusetti updated TAP5-500:
---------------------------------
Attachment: patch
Very simple patch
> Small typo in javadoc comments for Cookies service.
> ---------------------------------------------------
>
> Key: TAP5-500
> URL: https://issues.apache.org/jira/browse/TAP5-500
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.18, 5.0.19
> Reporter: Massimo Lusetti
> Priority: Trivial
> Attachments: patch
>
>
> Small typo in javadoc comments for Cookies service.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.