Re: [PR] fix(dashboard): is_externally_managed still allows edits [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #38584:
URL: https://github.com/apache/superset/pull/38584#issuecomment-5185854767

   @mkramer5454 lint-frontend is still red on this branch. Codeant's thread on `Dashboard.ts` flagged already that making `is_managed_externally` required breaks the `tsc` build because the `dashboard` fixture in `permissionUtils.test.ts` doesn't set it. Either give that fixture a default or keep the field optional on the frontend type. Holler if you want a hand in this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org