[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

[GitBox <gi...@apache.org>]

pratyakshsharma commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable
URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349453011
 
 

 ##########
 File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
 ##########
 @@ -170,10 +168,12 @@ public static long totalNewMessages(OffsetRange[] ranges) {
   /**
    * Configs to be passed for this source. All standard Kafka consumer configs are also respected
    */
-  static class Config {
+  public static class Config {
 
 Review comment:
   @leesf basically I did not want to create 2 copies of the variable DEFAULT_MAX_EVENTS_FROM_KAFKA_SOURCE. Hence made Config class public. If we define the same variable at 2 places (one in above and one in TestKafkaSource), then there are chances that they might go out of sync (someone might update one of them and forget to change the other). WDYT? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services