You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/07 06:19:42 UTC

[jira] [Commented] (FLINK-5727) Unify some API of batch and stream TableEnvironment

    [ https://issues.apache.org/jira/browse/FLINK-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855407#comment-15855407 ] 

ASF GitHub Bot commented on FLINK-5727:
---------------------------------------

GitHub user KurtYoung opened a pull request:

    https://github.com/apache/flink/pull/3281

    [FLINK-5727] [table] Unify some API of batch and stream TableEnvironment

    This PR contains 3 changes:
    
    1. move `sql` to base class
    2. unify `scan` and `ingest` to `scan`, and move to base class
    3. move `registerTableSource` to base class and change the parameter type from specific `BatchTableSource` or `StreamTableSource` to their base class: `TableSource`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KurtYoung/flink flink-5727

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3281
    
----
commit 8303b0c1c6320713daf212c6da4d72499c459e42
Author: Kurt Young <yk...@gmail.com>
Date:   2017-02-07T06:15:02Z

    [FLINK-5727] [table] Unify some API of batch and stream TableEnvironment

----


> Unify some API of batch and stream TableEnvironment
> ---------------------------------------------------
>
>                 Key: FLINK-5727
>                 URL: https://issues.apache.org/jira/browse/FLINK-5727
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Kurt Young
>            Assignee: Kurt Young
>
> Some API's implementation of current {{BatchTableEnvironment}} and {{StreamTableEnvironment}} is identical, like {{sql}}. And other API like {{registerTableSource}} and {{scan}} can be unified to the base class. (we can change {{ingest}} from {{StreamTableEnvironment}} to {{scan}} also)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)