[GitHub] kishorekasi commented on a change in pull request #1110: Issue 1109: Error out pending ops on TLS key mismatch exception

[GitBox <gi...@apache.org>]

kishorekasi commented on a change in pull request #1110: Issue 1109: Error out pending ops on TLS key mismatch exception
URL: https://github.com/apache/bookkeeper/pull/1110#discussion_r167673688
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 ##########
 @@ -1225,7 +1241,7 @@ public void operationComplete(Future<Channel> future) throws Exception {
                         if (future.isSuccess() && state == ConnectionState.CONNECTING) {
                             LOG.error("Connection state changed before TLS handshake completed {}/{}", addr, state);
                             rc = BKException.Code.BookieHandleNotAvailableException;
-                            closeChannel(future.get());
 
 Review comment:
   In the error scenario where there is a key mismatch, future obj is null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services