[GitHub] [spark] srowen commented on a change in pull request #26241: [SPARK-29585][WEBUI] Fix stagePage duration

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #26241: [SPARK-29585][WEBUI] Fix stagePage duration
URL: https://github.com/apache/spark/pull/26241#discussion_r339558911
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
 ##########
 @@ -417,19 +417,8 @@ private[ui] class StageDataSource(
       case Some(t) => UIUtils.formatDate(t)
       case None => "Unknown"
     }
-    val finishTime = stageData.completionTime.map(_.getTime()).getOrElse(currentTime)
-
-    // The submission time for a stage is misleading because it counts the time
-    // the stage waits to be launched. (SPARK-10930)
-    val duration = stageData.firstTaskLaunchedTime.map { date =>
-      val time = date.getTime()
-      if (finishTime > time) {
-        finishTime - time
-      } else {
-        None
-        currentTime - time
-      }
-    }
+
+    val duration = Some(stageData.executorRunTime)
 
 Review comment:
   Just to be clear, this is exactly the field used to compute min/max stats, etc?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org