You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2007/12/10 14:27:19 UTC
[pool] 1.3-1.4 compatibility
Thanks to Mark's help, we have resolved all of the issues marked for
1.4 other than POOL-107, which may not be a POOL bug or may have been
fixed by changes already made. I have started work on release notes
and site cleanup and noticed in tracing through changes since 1.3 that
there were some API contract changes made early on. In particular,
r385746 appears to implement some of the changes described in [1]. I
think we need to roll some/most of these changes back for 1.4. This
is a little tricky, since most of them really amount to making what
were imprecise and / or incorrectly documented APIs clear and
consistent, so it is not obvious that all should be reverted.
As of now, the only thing that I am certain we need to revert is the
change in the default testOnBorrow value for GOP, GKOP from false to
true. I will work through all of the diffs over the next couple of
days, run CLIRR and provide a complete list. I will create a 1.4
release branch with just the 1.x classes (no composite package) this
evening. We can revert changes there and leave trunk as is for 2.0
for now. More eyeballs on a) the recent changes to fix the timer and
sync bugs in trunk and b) the changelog will be helpful.
Phil
[1] http://www.nabble.com/-pool--roadmap-to1431371.html#a1435963
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] 1.3-1.4 compatibility
Posted by sebb <se...@gmail.com>.
On 12/12/2007, Rahul Akolkar <ra...@gmail.com> wrote:
> On 12/12/07, sebb <se...@gmail.com> wrote:
> <snip/>
> >
> > By the way, build.xml creates the build/ directory tree, but this is
> > not excluded from SVN, unlike dist/ and target/. Not sure how to
> > create an SVN property patch...
> >
> <snap/>
>
> Like any other patch. Or just commit (given the nature of this change).
OK - thanks, done in 1.4 branch.
> -Rahul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] 1.3-1.4 compatibility
Posted by Rahul Akolkar <ra...@gmail.com>.
On 12/12/07, sebb <se...@gmail.com> wrote:
<snip/>
>
> By the way, build.xml creates the build/ directory tree, but this is
> not excluded from SVN, unlike dist/ and target/. Not sure how to
> create an SVN property patch...
>
<snap/>
Like any other patch. Or just commit (given the nature of this change).
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] 1.3-1.4 compatibility
Posted by sebb <se...@gmail.com>.
On 12/12/2007, sebb <se...@gmail.com> wrote:
> On 12/12/2007, Phil Steitz <ph...@gmail.com> wrote:
> > Quick update on this.
> >
> > I created 1_4_RELEASE_BRANCH so we should be reviewing / patching the
> > code there for the release.
> >
> > Clirr flagged only the change in default values for
> > DEFAULT_TEST_ON_BORROW mentioned above. Among the changes described
> > in [1] that have been implemented, I think we need to roll back
> >
> > 0) change in DEFAULT_TEST_ON_BORROW values
> >
> > 1) the behavior change that forgoes validation prior to returning
> > newly created objects from the pool (see the diffs for e.g. GOP
> > rr385746)
> >
> > 2) the change to have [Keyed]PoolableObjectFactory getNumIdle and
> > getNumActive methods
> > return negative values if they aren't supported.
> >
> > I don't think the other changes, which improve robustness and
> > documentation, need to be rolled back or deferred to a 2.0.
> >
> > I will make the changes in 0)-2) in the 1.4 release branch and add
> > details on the other behavior changes to the release notes.
> >
> > I will cut the RC using maven 1 and generate release notes from
> > changes.xml. Patches on this and other site elements most welcome.
> > Also more eyeballs on the changes recently made and the changelog for
> > the core classes would be appreciated.
>
> There are a few Javadoc warnings, e.g. @see Object#wait should be @see
> Object#wait(). I'll add a patch to JIRA shortly in case you want to
> fix those.
Also added JIRA patch to add Java source and target to manifest used
by build.xml.
By the way, build.xml creates the build/ directory tree, but this is
not excluded from SVN, unlike dist/ and target/. Not sure how to
create an SVN property patch...
Also project.xml still refers to junit3.8.1, whereas pom says 3.8.2.
> > Thanks!
> >
> > Phil
> >
> > [1] http://www.nabble.com/-pool--roadmap-to1431371.html#a1435963
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] 1.3-1.4 compatibility
Posted by sebb <se...@gmail.com>.
On 12/12/2007, Phil Steitz <ph...@gmail.com> wrote:
> Quick update on this.
>
> I created 1_4_RELEASE_BRANCH so we should be reviewing / patching the
> code there for the release.
>
> Clirr flagged only the change in default values for
> DEFAULT_TEST_ON_BORROW mentioned above. Among the changes described
> in [1] that have been implemented, I think we need to roll back
>
> 0) change in DEFAULT_TEST_ON_BORROW values
>
> 1) the behavior change that forgoes validation prior to returning
> newly created objects from the pool (see the diffs for e.g. GOP
> rr385746)
>
> 2) the change to have [Keyed]PoolableObjectFactory getNumIdle and
> getNumActive methods
> return negative values if they aren't supported.
>
> I don't think the other changes, which improve robustness and
> documentation, need to be rolled back or deferred to a 2.0.
>
> I will make the changes in 0)-2) in the 1.4 release branch and add
> details on the other behavior changes to the release notes.
>
> I will cut the RC using maven 1 and generate release notes from
> changes.xml. Patches on this and other site elements most welcome.
> Also more eyeballs on the changes recently made and the changelog for
> the core classes would be appreciated.
There are a few Javadoc warnings, e.g. @see Object#wait should be @see
Object#wait(). I'll add a patch to JIRA shortly in case you want to
fix those.
> Thanks!
>
> Phil
>
> [1] http://www.nabble.com/-pool--roadmap-to1431371.html#a1435963
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [pool] 1.3-1.4 compatibility
Posted by Phil Steitz <ph...@gmail.com>.
Quick update on this.
I created 1_4_RELEASE_BRANCH so we should be reviewing / patching the
code there for the release.
Clirr flagged only the change in default values for
DEFAULT_TEST_ON_BORROW mentioned above. Among the changes described
in [1] that have been implemented, I think we need to roll back
0) change in DEFAULT_TEST_ON_BORROW values
1) the behavior change that forgoes validation prior to returning
newly created objects from the pool (see the diffs for e.g. GOP
rr385746)
2) the change to have [Keyed]PoolableObjectFactory getNumIdle and
getNumActive methods
return negative values if they aren't supported.
I don't think the other changes, which improve robustness and
documentation, need to be rolled back or deferred to a 2.0.
I will make the changes in 0)-2) in the 1.4 release branch and add
details on the other behavior changes to the release notes.
I will cut the RC using maven 1 and generate release notes from
changes.xml. Patches on this and other site elements most welcome.
Also more eyeballs on the changes recently made and the changelog for
the core classes would be appreciated.
Thanks!
Phil
[1] http://www.nabble.com/-pool--roadmap-to1431371.html#a1435963
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org