[GitHub] [spark] HyukjinKwon commented on a change in pull request #26820: [WIP][SPARK-30194][BUILD][test-maven] Re-enable checkstyle for Java

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #26820: [WIP][SPARK-30194][BUILD][test-maven] Re-enable checkstyle for Java
URL: https://github.com/apache/spark/pull/26820#discussion_r355799420
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -2786,7 +2786,7 @@
         <artifactId>maven-checkstyle-plugin</artifactId>
         <version>3.1.0</version>
         <configuration>
-          <failOnViolation>false</failOnViolation>
+          <failOnViolation>true</failOnViolation>
 
 Review comment:
   Alternatively, we can just completely switch `linter-java` to `sbt-checkstyle` completely so that we don't suffer from the differences anymore.
   
   I have seen some differences so far, e.g. https://github.com/apache/spark/pull/26818 and https://github.com/apache/spark/pull/21801
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org