You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/12/18 06:35:06 UTC

[kudu-CR] [docs] add a note on Token Authentication

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18107


Change subject: [docs] add a note on Token Authentication
......................................................................

[docs] add a note on Token Authentication

Added a note about the token authentication in KRPC, clarifying on
the information needed on the client side for token-based authentication
with the server.

Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
---
M docs/design-docs/rpc.md
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/18107/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
Gerrit-Change-Number: 18107
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [docs] add a note on Token Authentication

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18107

to look at the new patch set (#3).

Change subject: [docs] add a note on Token Authentication
......................................................................

[docs] add a note on Token Authentication

Added a note about the token authentication in KRPC, clarifying on
the information needed on the client side for token-based authentication
with the server.

Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
---
M docs/design-docs/rpc.md
1 file changed, 23 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/18107/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
Gerrit-Change-Number: 18107
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docs] add a note on Token Authentication

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18107 )

Change subject: [docs] add a note on Token Authentication
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18107/2/docs/design-docs/rpc.md
File docs/design-docs/rpc.md:

http://gerrit.cloudera.org:8080/#/c/18107/2/docs/design-docs/rpc.md@612
PS2, Line 612: So in addition to the authentication
             : token, the client also needs to be provided with the certificate of the trusted
             : CA to be able to verify the server's certificate as a part of the TLS handshake.
Would it make sense to add this as a part of the diagram below?



-- 
To view, visit http://gerrit.cloudera.org:8080/18107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
Gerrit-Change-Number: 18107
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 18 Dec 2021 09:25:03 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] add a note on Token Authentication

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18107 )

Change subject: [docs] add a note on Token Authentication
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18107/2/docs/design-docs/rpc.md
File docs/design-docs/rpc.md:

http://gerrit.cloudera.org:8080/#/c/18107/2/docs/design-docs/rpc.md@612
PS2, Line 612: So in addition to the authentication
             : token, the client also needs to be provided with the certificate of the trusted
             : CA to be able to verify the server's certificate as a part of the TLS handshake.
> Would it make sense to add this as a part of the diagram below?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
Gerrit-Change-Number: 18107
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 18 Dec 2021 18:18:54 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] add a note on Token Authentication

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18107

to look at the new patch set (#2).

Change subject: [docs] add a note on Token Authentication
......................................................................

[docs] add a note on Token Authentication

Added a note about the token authentication in KRPC, clarifying on
the information needed on the client side for token-based authentication
with the server.

Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
---
M docs/design-docs/rpc.md
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/18107/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
Gerrit-Change-Number: 18107
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docs] add a note on Token Authentication

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18107 )

Change subject: [docs] add a note on Token Authentication
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
Gerrit-Change-Number: 18107
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 04 Jan 2022 19:00:10 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] add a note on Token Authentication

Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18107 )

Change subject: [docs] add a note on Token Authentication
......................................................................

[docs] add a note on Token Authentication

Added a note about the token authentication in KRPC, clarifying on
the information needed on the client side for token-based authentication
with the server.

Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
Reviewed-on: http://gerrit.cloudera.org:8080/18107
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docs/design-docs/rpc.md
1 file changed, 23 insertions(+), 10 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If3fdf3c9fb1b881e0ae3f02bb1de1ca6eefc3df0
Gerrit-Change-Number: 18107
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>