[GitHub] [iceberg] kbendick commented on a diff in pull request #4716: [WIP] [CORE] - Add remaining parsers for MetadataUpdate implementations

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4716:
URL: https://github.com/apache/iceberg/pull/4716#discussion_r867033954


##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -72,6 +75,20 @@ private MetadataUpdateParser() {
   // AddSortOrder
   private static final String SORT_ORDER = "sort-order";
 
+  // SetDefaultSortOrder
+  private static final String SORT_ORDER_ID = "sort-order-id";

Review Comment:
   This field is called `order-id` in the spec.
   
   Due to discussion in #4693  , we've decided to align the names `order-id` and `write-order-id` on `sort-order-id` (and `default-sort-order-id`) to match the existing code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org