You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/20 04:19:12 UTC

[GitHub] [couchdb] nickva commented on issue #2571: Add fdb_to_revinfo compatibility with 5-tuple Val

nickva commented on issue #2571: Add fdb_to_revinfo compatibility with 5-tuple Val
URL: https://github.com/apache/couchdb/pull/2571#issuecomment-588601449
 
 
   I think the bug here is in the sizes PR a few commits back:
   
   https://github.com/apache/couchdb/commit/eb1a09e114dafc55fa9511d477b9ada4350134eb#diff-32274bcb4785f432811085d2e08c3580
   
   (And I did miss it during the review, sorry about that)
   
   There are compatibility clauses there https://github.com/apache/couchdb/blob/prototype/fdb-layer/src/fabric/src/fabric2_fdb.erl#L1272 to upgrade from rev format `0 -> 1` and `1 -> 2`. However `0 -> 1` became broken because it uses the `?CURR_REV_FORMAT` macro which was bumped from `1` to `2` in that commit. So we are effectively doing a `0` -> `2` jump but with version `1` tuple format. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services