Re: [PR] fix(BarView): borderColor hides bar color with large data. close #18185 [echarts]

["DevitX (via GitHub)" <gi...@apache.org>]

DevitX commented on PR #20465:
URL: https://github.com/apache/echarts/pull/20465#issuecomment-2452110752

   > I'm not sure about if we should change like this. Is it expected to show fill color instead of stroke color in large scale bars? A reason to say NO for me is that the stoke width is a fixed width (etc. 1px) while the bar width is relatively quite small when in large scale bars, far less than 1px. So I would prefer to expect showing border color in this case.
   
   Hi @Ovilia, thank you for your review! I believe that the expected behavior for a user is that: changing the border color should only affect the border even in large data, resulting in a bar with a distinct inner color and outer border. However in this case, since that is not possibile (like you said for very small width) with larger datasets, you end up with a single color and that can be quite messy. In this example: applying a black border:
   ![image](https://github.com/user-attachments/assets/1c4be02f-e5c9-4582-9049-645ca6a7bd82)
   
   A possible solution might be to ignore user-defined colors at high data density, displaying the chart as if no borderColor is specified. This would revert to a simpler, default color scheme for clarity. And on zoom to less dense data, apply the correct property. What do you think about this? The default color is this:
   ![image](https://github.com/user-attachments/assets/b93495f9-f407-4ba5-a4a3-0e498d7f9cb2)
   
   @nico-robert what behavior did you expect?
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org