You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2012/05/01 22:10:47 UTC

[jira] [Created] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Robert Joseph Evans created HADOOP-8341:
-------------------------------------------

             Summary: Fix or filter findbugs issues in hadoop-tools
                 Key: HADOOP-8341
                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
             Project: Hadoop Common
          Issue Type: Bug
    Affects Versions: 3.0.0
            Reporter: Robert Joseph Evans
            Assignee: Robert Joseph Evans


Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266084#comment-13266084 ] 

Robert Joseph Evans commented on HADOOP-8341:
---------------------------------------------

This is the breakdown of the existing findbugs issues.

 * Streaming - 7 (mostly returning internal data)
 * distcp - 2 (threading issues)
 * archives - 1 (casting Configuration to JobConf)
 * Rumen - 8 (returning internal data and serialization)
 * extras - 2 (some things should be marked final)

                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8341:
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.0
                   2.0.0
                   0.23.3
           Status: Resolved  (was: Patch Available)
    
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8341:
----------------------------------------

    Status: Patch Available  (was: Open)
    
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270457#comment-13270457 ] 

Hudson commented on HADOOP-8341:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2204 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2204/])
    HADOOP-8341. Fix or filter findbugs issues in hadoop-tools (bobby) (Revision 1335505)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335505
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
* /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/DeskewedJobTraceReader.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobConfPropertyNames.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedNetworkTopology.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/TraceBuilder.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordListAnonymizerUtility.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/NodeName.java
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java

                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271430#comment-13271430 ] 

Hudson commented on HADOOP-8341:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1074 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1074/])
    HADOOP-8341. Fix or filter findbugs issues in hadoop-tools (bobby) (Revision 1335505)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335505
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
* /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/DeskewedJobTraceReader.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobConfPropertyNames.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedNetworkTopology.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/TraceBuilder.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordListAnonymizerUtility.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/NodeName.java
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java

                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270481#comment-13270481 ] 

Hudson commented on HADOOP-8341:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2221 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2221/])
    HADOOP-8341. Fix or filter findbugs issues in hadoop-tools (bobby) (Revision 1335505)

     Result = ABORTED
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335505
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
* /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/DeskewedJobTraceReader.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobConfPropertyNames.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedNetworkTopology.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/TraceBuilder.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordListAnonymizerUtility.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/NodeName.java
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java

                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269731#comment-13269731 ] 

Robert Joseph Evans commented on HADOOP-8341:
---------------------------------------------

The javadoc issues are unrelated, and are being covered by a separate JIRA.  No tests were included because no functionality should have changed, just cleared up some findbugs issues for defensive programming.
                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268665#comment-13268665 ] 

Hadoop QA commented on HADOOP-8341:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525669/HADOOP-8341.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    -1 release audit.  The applied patch generated 1 release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-tools/hadoop-archives hadoop-tools/hadoop-distcp hadoop-tools/hadoop-extras hadoop-tools/hadoop-rumen hadoop-tools/hadoop-streaming:

                  org.apache.hadoop.tools.mapred.TestUniformSizeInputFormat

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/941//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/941//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/941//console

This message is automatically generated.
                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269715#comment-13269715 ] 

Hadoop QA commented on HADOOP-8341:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525860/HADOOP-8341.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-tools/hadoop-archives hadoop-tools/hadoop-distcp hadoop-tools/hadoop-extras hadoop-tools/hadoop-rumen hadoop-tools/hadoop-streaming.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/949//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/949//console

This message is automatically generated.
                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8341:
----------------------------------------

    Status: Patch Available  (was: Open)
    
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8341:
----------------------------------------

    Status: Open  (was: Patch Available)

Addressing the missing license statement in findbugs exclude file.  The test passes for me locally.  I think it is caused by running with an older version of an HDFS jar, so I am going to upload the new patch and see if that fixes it.
                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271377#comment-13271377 ] 

Hudson commented on HADOOP-8341:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #252 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/252/])
    svn merge -c 1335505 FIXES: HADOOP-8341. Fix or filter findbugs issues in hadoop-tools (bobby) (Revision 1335507)

     Result = UNSTABLE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335507
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/dev-support
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/dev-support/findbugs-exclude.xml
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/DeskewedJobTraceReader.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobConfPropertyNames.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedNetworkTopology.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/TraceBuilder.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordListAnonymizerUtility.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/NodeName.java
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/dev-support
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/dev-support/findbugs-exclude.xml
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/pom.xml
* /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java

                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8341:
----------------------------------------

    Attachment: HADOOP-8341.txt
    
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271388#comment-13271388 ] 

Hudson commented on HADOOP-8341:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1039 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1039/])
    HADOOP-8341. Fix or filter findbugs issues in hadoop-tools (bobby) (Revision 1335505)

     Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335505
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
* /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/DeskewedJobTraceReader.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobConfPropertyNames.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedNetworkTopology.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/TraceBuilder.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordListAnonymizerUtility.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/NodeName.java
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java

                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270456#comment-13270456 ] 

Hudson commented on HADOOP-8341:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2279 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2279/])
    HADOOP-8341. Fix or filter findbugs issues in hadoop-tools (bobby) (Revision 1335505)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335505
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-tools/hadoop-archives/src/main/java/org/apache/hadoop/tools/HadoopArchives.java
* /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
* /hadoop/common/trunk/hadoop-tools/hadoop-extras/src/main/java/org/apache/hadoop/tools/Logalyzer.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/DeskewedJobTraceReader.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/JobConfPropertyNames.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/LoggedNetworkTopology.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/TraceBuilder.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/anonymization/WordListAnonymizerUtility.java
* /hadoop/common/trunk/hadoop-tools/hadoop-rumen/src/main/java/org/apache/hadoop/tools/rumen/datatypes/NodeName.java
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/dev-support/findbugs-exclude.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/pom.xml
* /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamJob.java

                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269743#comment-13269743 ] 

Tom White commented on HADOOP-8341:
-----------------------------------

+1
                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8341.txt, HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8341) Fix or filter findbugs issues in hadoop-tools

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8341:
----------------------------------------

    Attachment: HADOOP-8341.txt

This patch fixes most of the findbugs issues, but also filters out a few of them where changes looked like they may impact the overall functionality of the code.
                
> Fix or filter findbugs issues in hadoop-tools
> ---------------------------------------------
>
>                 Key: HADOOP-8341
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8341
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HADOOP-8341.txt
>
>
> Now that the precommit build can test hadoop-tools we need to fix or filter the many findbugs warnings that are popping up in there.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira