You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/13 02:45:25 UTC

[GitHub] [flink] trushev opened a new pull request, #20261: [FLINK-28530] Improvement of extraction of conditions that can be pushed into join inputs

trushev opened a new pull request, #20261:
URL: https://github.com/apache/flink/pull/20261

   
   ## What is the purpose of the change
   
   This PR is aimed at replacing current extraction algorithm with new one which covers more complex case with deep nested predicate:
   for all n > 0
   ((((((((a0 and b0) or a1) and b1) or a2) and b2) or a3) ... and bn-1) or an) => (a0 or a1 or ... or an)
   
   ## Brief change log
   
     - Introduced new algorithm placed in `FlinkRexExtract`
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added unit tests for extraction `FlinkRexExtractTest`
     - Added test to `JoinTest` to verify changed sql plan
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] trushev commented on pull request #20261: [FLINK-28530] Improvement of extraction of conditions that can be pushed into join inputs

Posted by GitBox <gi...@apache.org>.
trushev commented on PR #20261:
URL: https://github.com/apache/flink/pull/20261#issuecomment-1182786906

   `CassandraConnectorITCase` failed on CI but it shouldn't have been affected by this changes and it works fine locally. Triggering pipeline again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] trushev closed pull request #20261: [FLINK-28530][table-planner] Improvement of extraction of conditions that can be pushed into join inputs

Posted by GitBox <gi...@apache.org>.
trushev closed pull request #20261: [FLINK-28530][table-planner] Improvement of extraction of conditions that can be pushed into join inputs
URL: https://github.com/apache/flink/pull/20261


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20261: [FLINK-28530] Improvement of extraction of conditions that can be pushed into join inputs

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20261:
URL: https://github.com/apache/flink/pull/20261#issuecomment-1182705940

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "221a9ecd46069d80583c766bf39f095714801f88",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "221a9ecd46069d80583c766bf39f095714801f88",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 221a9ecd46069d80583c766bf39f095714801f88 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] trushev commented on pull request #20261: [FLINK-28530] Improvement of extraction of conditions that can be pushed into join inputs

Posted by GitBox <gi...@apache.org>.
trushev commented on PR #20261:
URL: https://github.com/apache/flink/pull/20261#issuecomment-1182786958

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org