You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampipes.apache.org by "dominikriemer (via GitHub)" <gi...@apache.org> on 2023/06/05 14:51:25 UTC
[I] Update_versions script of installer is broken (streampipes)
dominikriemer opened a new issue, #1659:
URL: https://github.com/apache/streampipes/issues/1659
### Body
To bump the current StreamPipes version in the various installers (docker-compose, CLI and k8s helm charts), we use the `upgrade_version.sh` script in the `installer` folder.
After some changes to the `values.yaml file, the versions script seems to be broken as it not only replaces StreamPipes versions, but also the versions of Consul, CouchDB and InfluxDB.
* Link to the commit where the bug was first seen: https://github.com/apache/streampipes/pull/1658/commits/b3ff92127ee7a41e89ea91df4501160ef9c9e245
* How to resolve
Revisit the logic in the `upgrade_versions` module and make sure that only the versions related to StreamPipes are updated.
### StreamPipes Committer
I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1639950361
Thanks for reminding me of this issue. @bossenti
Yes. This is related to the upgrading support of the OSPP challenge. @luoluoyuyu Could you take a look at this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "loststar (via GitHub)" <gi...@apache.org>.
loststar commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1585613719
> Another approach could be to check the current version and only replace those values
Great idea! However, this behavior could be risky if the version of StreamPipes is the same as the version of other components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer closed issue #1659: Update_versions script of installer is broken
URL: https://github.com/apache/streampipes/issues/1659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1639585423
@RobertIndie how is the status of the OSPP challenge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "loststar (via GitHub)" <gi...@apache.org>.
loststar commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1586994759
I have a couple of ideas that might be helpful, but I'm not sure if they're good ideas or not.
- Add locators like [this](https://github.com/apache/streampipes/blob/7fff17c768f7511d39bed38ed7dc455c1058670f/installer/k8s/README.md?plain=1#L21) to the file to help improve the script positioning.
- Explore using [ConfigMaps](https://kubernetes.io/docs/concepts/configuration/configmap/) in k8s. Maybe this could potentially help us use an alias to replace the value of StreamPipes' version.
BTW, maybe we can use the previous PR as a workaround and keep this issue open for further exploration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "loststar (via GitHub)" <gi...@apache.org>.
loststar commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1585504098
Hi @dominikriemer, maybe I can have a try. I think we can simply match the `version` field between the `streampipes` and `external` sections to solve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1589576106
> I have a couple of ideas that might be helpful, but I'm not sure if they're good ideas or not.
>
> * Add locators like [this](https://github.com/apache/streampipes/blob/7fff17c768f7511d39bed38ed7dc455c1058670f/installer/k8s/README.md?plain=1#L21) to the file to help improve the script positioning.
>
> * Explore using [ConfigMaps](https://kubernetes.io/docs/concepts/configuration/configmap/) in k8s. Maybe this could potentially help us use an alias to replace the value of StreamPipes' version.
>
>
> BTW, maybe we can use the previous PR as a workaround and keep this issue open for further exploration.
Thanks a lot for your input @loststar 🙏🏼
FYI: this might relate to a project we have in this year's OSPP challenge: https://summer-ospp.ac.cn/org/prodetail/23fc00416?lang=en&list=pro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "luoluoyuyu (via GitHub)" <gi...@apache.org>.
luoluoyuyu commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1641601582
Hi @bossenti,
I have executed the script, and it appears that the Update_versions script can only modify the version number of Streampipes. Is the question we are facing about precisely determining the location where the version number needs to be changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1587138656
Thanks, yes I agree. We should merge your PR and leave this issue open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "loststar (via GitHub)" <gi...@apache.org>.
loststar commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1585713741
Hi @tenthe, I've drafted a version that works well, but we still need to discuss the special cases mentioned before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1586608328
Hi,
thanks for the PR.
You are right the script will not work for this case.
Unfortunately, I do not have a good idea yet except for checking the git diff manually after running the script 🤔
Do you have an idea how we could catch this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "loststar (via GitHub)" <gi...@apache.org>.
loststar commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1638307807
> > I have a couple of ideas that might be helpful, but I'm not sure if they're good ideas or not.
> > ```
> > * Add locators like [this](https://github.com/apache/streampipes/blob/7fff17c768f7511d39bed38ed7dc455c1058670f/installer/k8s/README.md?plain=1#L21) to the file to help improve the script positioning.
> >
> > * Explore using [ConfigMaps](https://kubernetes.io/docs/concepts/configuration/configmap/) in k8s. Maybe this could potentially help us use an alias to replace the value of StreamPipes' version.
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > BTW, maybe we can use the previous PR as a workaround and keep this issue open for further exploration.
>
> Thanks a lot for your input @loststar 🙏🏼 FYI: this might relate to a project we have in this year's OSPP challenge: https://summer-ospp.ac.cn/org/prodetail/23fc00416?lang=en&list=pro
Thanks for the information. If the OSPP participants will refine this feature, I'm willing to stay engaged in the discussion, or I'll continue to follow this issue. @bossenti
After consideration, I think the following approach aligns better with our goals: incorporating specific comments before and after the version number, similar to [this example](https://github.com/apache/streampipes/blob/7130732f53b603db1c805b6d7785c609ac107024/installer/k8s/README.md?plain=1#L21-L23), and utilizing a script to match the version number within the restricted section. I will make an attempt to draft a version at a later date to assess its effectiveness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1585596949
Another approach could be to check the current version and only replace those values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1639978952
@loststar thank you very much for your input here 🙏
Would be great if you continue bringing your knowledge into to discussion 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1659:
URL: https://github.com/apache/streampipes/issues/1659#issuecomment-1646831492
Yes, if my understanding is correct
@dominikriemer am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Update_versions script of installer is broken
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer closed issue #1659: Update_versions script of installer is broken
URL: https://github.com/apache/streampipes/issues/1659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org