[jira] [Commented] (WICKET-5350) Enhancement for AbstractChoice and WildcardListModel API

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075494#comment-14075494 ] 

ASF subversion and git services commented on WICKET-5350:
---------------------------------------------------------

Commit a04fc96a7289c5c0f46511a6e70f3cee542d0c9a in wicket's branch refs/heads/WICKET-5350-wildcards from svenmeier
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=a04fc96 ]

WICKET-5350 adjust components' wildcards

> Enhancement for AbstractChoice and WildcardListModel API
> --------------------------------------------------------
>
>                 Key: WICKET-5350
>                 URL: https://issues.apache.org/jira/browse/WICKET-5350
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 6.10.0, 7.0.0-M1
>            Reporter: Betlista
>            Assignee: Sven Meier
>            Priority: Minor
>              Labels: generics
>
> According to Efective Java book (http://devender.files.wordpress.com/2008/05/effectivejava.pdf), item 28:
> "No wildcard type for return value"
> Especially "User should not have to think about wildcards to use your API".
> so
> public List<? extends E> getChoices()
> should be changed to
> public List<E> getChoices()
> and for WildcardListModel
> protected List<? extends T> createSerializableVersionOf(List<? extends T> object)
> should be changed to
> protected List<T> createSerializableVersionOf(List<? extends T> object)
> Probably there is a lot of such things in framework.



--
This message was sent by Atlassian JIRA
(v6.2#6252)