You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Ceilzcx (via GitHub)" <gi...@apache.org> on 2023/09/05 12:00:23 UTC
[GitHub] [shenyu] Ceilzcx opened a new pull request, #5120: update dubbo version and some deprecated method
Ceilzcx opened a new pull request, #5120:
URL: https://github.com/apache/shenyu/pull/5120
<!-- Describe your PR here; eg. Fixes #issueNo -->
#5068
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] Ceilzcx commented on pull request #5120: update dubbo version and some deprecated method
Posted by "Ceilzcx (via GitHub)" <gi...@apache.org>.
Ceilzcx commented on PR #5120:
URL: https://github.com/apache/shenyu/pull/5120#issuecomment-1723176135
又仔细看了一下，【org.apache.dubbo.config.RegistryConfig#setAddress】最耗时的方法是这个，看了一下源码也没有什么复杂的逻辑，不知道为什么本地启动的时候就很慢，耗时3秒多
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] Ceilzcx commented on pull request #5120: update dubbo version and some deprecated method
Posted by "Ceilzcx (via GitHub)" <gi...@apache.org>.
Ceilzcx commented on PR #5120:
URL: https://github.com/apache/shenyu/pull/5120#issuecomment-1723078140
@dragon-zhang
我在org.apache.shenyu.plugin.base.AbstractShenyuPlugin#execute方法最前面打了日志，这里在org.apache.shenyu.e2e.testcase.apachedubbo.ApacheDubboPluginTest#before，也就是调用"http://xxx:9195/dubbo/findAll"的时候会调用到，查看日志可以发现"shenyu use plugin:[dubbo]"的日志在check调用之后，这个时候ApacheDubboPlugin还没有加入org.apache.shenyu.web.handler.ShenyuWebHandler#plugins，找不到对应的plugin，导致ci的时候一直会报错。
我看了一下主要是org.apache.shenyu.plugin.apache.dubbo.handler.ApacheDubboPluginDataHandler#initConfigCache这边调用时间比较长，我本地跑的时候打了一下日志，差不多4s，所以我在e2e这边加了一些等待ApacheDubboPlugin加入到list的代码
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang merged pull request #5120: update dubbo version and some deprecated method
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang merged PR #5120:
URL: https://github.com/apache/shenyu/pull/5120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #5120: update dubbo version and some deprecated method
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5120:
URL: https://github.com/apache/shenyu/pull/5120#issuecomment-1709434810
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5120?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5120](https://app.codecov.io/gh/apache/shenyu/pull/5120?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5c559fe) into [master](https://app.codecov.io/gh/apache/shenyu/commit/f2b10010c68cd0f8690753a045bcac54b3efefb0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f2b1001) will **decrease** coverage by `0.66%`.
> The diff coverage is `85.71%`.
```diff
@@ Coverage Diff @@
## master #5120 +/- ##
============================================
- Coverage 61.69% 61.04% -0.66%
+ Complexity 8496 8427 -69
============================================
Files 1232 1232
Lines 36990 36990
Branches 3512 3508 -4
============================================
- Hits 22820 22579 -241
- Misses 12210 12501 +291
+ Partials 1960 1910 -50
```
| [Files Changed](https://app.codecov.io/gh/apache/shenyu/pull/5120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...enyu/plugin/transform/RpcParamTransformPlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/5120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tdHJhbnNmb3JtL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3RyYW5zZm9ybS9ScGNQYXJhbVRyYW5zZm9ybVBsdWdpbi5qYXZh) | `84.21% <ø> (ø)` | |
| [.../shenyu/plugin/apache/dubbo/ApacheDubboPlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/5120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZHViYm8vc2hlbnl1LXBsdWdpbi1hcGFjaGUtZHViYm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYXBhY2hlL2R1YmJvL0FwYWNoZUR1YmJvUGx1Z2luLmphdmE=) | `70.00% <75.00%> (ø)` | |
| [...apache/dubbo/proxy/ApacheDubboGrayLoadBalance.java](https://app.codecov.io/gh/apache/shenyu/pull/5120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tcnBjL3NoZW55dS1wbHVnaW4tZHViYm8vc2hlbnl1LXBsdWdpbi1hcGFjaGUtZHViYm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYXBhY2hlL2R1YmJvL3Byb3h5L0FwYWNoZUR1YmJvR3JheUxvYWRCYWxhbmNlLmphdmE=) | `100.00% <100.00%> (ø)` | |
... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5120/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org