You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Idcmp (JIRA)" <ji...@codehaus.org> on 2011/01/06 22:06:57 UTC

[jira] Created: (MCHECKSTYLE-149) supressionsFileExpression does not work.

supressionsFileExpression does not work.
----------------------------------------

                 Key: MCHECKSTYLE-149
                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-149
             Project: Maven 2.x Checkstyle Plugin
          Issue Type: Bug
    Affects Versions: 2.6
            Reporter: Idcmp


In DefaultCheckstyleExecutor.getOverridingProperties() there is the following:
{code:java}
  if ( request.getSuppressionsFileExpression() != null )
        {
            String suppresionFile = request.getSuppressionsFileExpression();

            if ( suppresionFile != null )
            {
                p.setProperty( request.getSuppressionsFileExpression(), suppresionFile );
            }
        }
{code}

Note how supressionFile is being set to the *expression*, not the *file*.  This one line should read:

{code:java}
            String suppresionFile = request.getSuppressionsLocation();
{code}

This bug is blocking the m2e-checkstyle plugin from supporting Maven-driven suppression files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Closed: (MCHECKSTYLE-149) supressionsFileExpression does not work.

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCHECKSTYLE-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MCHECKSTYLE-149.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.7
         Assignee: Dennis Lundberg

Patch applied in [r1092500|http://svn.apache.org/viewvc?view=revision&revision=1092500].

Thanks!

New 2.7-SNAPSHOT deployed. Please test it.

> supressionsFileExpression does not work.
> ----------------------------------------
>
>                 Key: MCHECKSTYLE-149
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-149
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.6
>            Reporter: Idcmp
>            Assignee: Dennis Lundberg
>             Fix For: 2.7
>
>
> In DefaultCheckstyleExecutor.getOverridingProperties() there is the following:
> {code:java}
>   if ( request.getSuppressionsFileExpression() != null )
>         {
>             String suppresionFile = request.getSuppressionsFileExpression();
>             if ( suppresionFile != null )
>             {
>                 p.setProperty( request.getSuppressionsFileExpression(), suppresionFile );
>             }
>         }
> {code}
> Note how supressionFile is being set to the *expression*, not the *file*.  This one line should read:
> {code:java}
>             String suppresionFile = request.getSuppressionsLocation();
> {code}
> This bug is blocking the m2e-checkstyle plugin from supporting Maven-driven suppression files.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira