You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/14 20:52:23 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24404: chore: deprecate FLASK_ENV and improve conf.ENVIRONMENT_TAG_CONFIG
codecov[bot] commented on PR #24404:
URL: https://github.com/apache/superset/pull/24404#issuecomment-1591968252
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24404?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24404](https://app.codecov.io/gh/apache/superset/pull/24404?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ec14d52) into [master](https://app.codecov.io/gh/apache/superset/commit/17e79ace794b58e32fe5b91ab5725de33d9fbc38?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (17e79ac) will **decrease** coverage by `10.85%`.
> The diff coverage is `85.71%`.
> :exclamation: Current head ec14d52 differs from pull request most recent head 56e65d8. Consider uploading reports for the commit 56e65d8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24404 +/- ##
===========================================
- Coverage 68.95% 58.11% -10.85%
===========================================
Files 1903 1903
Lines 74070 74071 +1
Branches 8110 8110
===========================================
- Hits 51077 43048 -8029
- Misses 20881 28911 +8030
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.86% <85.71%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.79% <85.71%> (+<0.01%)` | :arrow_up: |
| python | `60.79% <85.71%> (-22.52%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.55% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://app.codecov.io/gh/apache/superset/pull/24404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.37% <0.00%> (-0.60%)` | :arrow_down: |
| [superset/views/base.py](https://app.codecov.io/gh/apache/superset/pull/24404?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `58.10% <100.00%> (-14.69%)` | :arrow_down: |
... and [300 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24404/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org