You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/13 03:42:41 UTC
[GitHub] [incubator-kvrocks] tanruixiang opened a new pull request, #1114: Fix modernize-use-using warning reported by clang-tidy
tanruixiang opened a new pull request, #1114:
URL: https://github.com/apache/incubator-kvrocks/pull/1114
This close #1101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1114: Fix modernize-use-using warning reported by clang-tidy
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1114:
URL: https://github.com/apache/incubator-kvrocks/pull/1114#issuecomment-1314845998
Thanks all. Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1114: Fix modernize-use-using warning reported by clang-tidy
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #1114:
URL: https://github.com/apache/incubator-kvrocks/pull/1114#discussion_r1020909355
##########
src/common/sha1.cc:
##########
@@ -79,10 +79,10 @@ A million repetitions of "a"
void SHA1Transform(uint32_t state[5], const unsigned char buffer[64]) {
uint32_t a, b, c, d, e;
- typedef union {
+ using CHAR64LONG16 = union {
Review Comment:
```suggestion
union CHAR64LONG16 {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1114: Fix modernize-use-using warning reported by clang-tidy
Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #1114:
URL: https://github.com/apache/incubator-kvrocks/pull/1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org