You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/12/29 16:47:12 UTC

[PR] fix: Duplicated plugin registration [superset]

michael-s-molina opened a new pull request, #26379:
URL: https://github.com/apache/superset/pull/26379

   ### SUMMARY
   This PR removes the duplicated plugin registration that generates the following type of warning:
   
   ```
   Item with key "deck_arc" already exists. You are assigning a new value.
   Item with key "deck_arc" already exists. You are assigning a new value.
   Item with key "big_number" already exists. You are assigning a new value.
   Item with key "box_plot" already exists. You are assigning a new value.
   ```
   
   The duplicate registration was necessary when those pages belonged to different React apps. Now, they belong to the same app which makes the registration unnecessary.
   
   The registration should happen only once when the [application initializes](https://github.com/apache/superset/blob/3a0391bbb9138f1a3dab4d3c10d08e5520a4274d/superset-frontend/src/views/App.tsx#L45).
   
   ### TESTING INSTRUCTIONS
   1 - Open any dashboard
   2 - Check that the warnings are not there anymore
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: Duplicated plugin registration [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #26379:
URL: https://github.com/apache/superset/pull/26379#issuecomment-3210340899

   There are only 2 places in master calling `setupPlugins()`:
   
   
   [src/views/App.tsx](https://github.com/apache/superset/blob/48699a71946fd5981dba1f6d2cfabd0315137889/superset-frontend/src/views/App.tsx#L46)
   [src/embedded/index.tsx](https://github.com/apache/superset/blob/48699a71946fd5981dba1f6d2cfabd0315137889/superset-frontend/src/embedded/index.tsx#L48)
   
   @Vitor-Avila @rusackas You might want to check if this call is required for Embedded.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: Duplicated plugin registration [superset]

Posted by "alephpt (via GitHub)" <gi...@apache.org>.
alephpt commented on PR #26379:
URL: https://github.com/apache/superset/pull/26379#issuecomment-3201711366

   Still seeing this problem in 5.0.0. Any advice?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: Duplicated plugin registration [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #26379:
URL: https://github.com/apache/superset/pull/26379#issuecomment-3208215387

   ~~OMG THANK YOU. That's been nagging at me forever!~~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: Duplicated plugin registration [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #26379:
URL: https://github.com/apache/superset/pull/26379


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: Duplicated plugin registration [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #26379:
URL: https://github.com/apache/superset/pull/26379#issuecomment-3208167496

   OMG THANK YOU. That's been nagging at me forever!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: Duplicated plugin registration [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26379:
URL: https://github.com/apache/superset/pull/26379#issuecomment-1872246904

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/26379?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`863f8bb`)](https://app.codecov.io/gh/apache/superset/commit/863f8bbbcdd078814973d444368c12e06ad0c0c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.18% compared to head [(`dc37653`)](https://app.codecov.io/gh/apache/superset/pull/26379?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.14%.
   > Report is 3 commits behind head on master.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #26379      +/-   ##
   ==========================================
   - Coverage   69.18%   69.14%   -0.04%     
   ==========================================
     Files        1946     1946              
     Lines       75988    75986       -2     
     Branches     8479     8479              
   ==========================================
   - Hits        52570    52541      -29     
   - Misses      21228    21266      +38     
   + Partials     2190     2179      -11     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/26379/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/26379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.46% <ø> (-0.08%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/26379?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: Duplicated plugin registration [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #26379:
URL: https://github.com/apache/superset/pull/26379#issuecomment-3226443985

   Both these calls probably shouldn't be module-scoped ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: Duplicated plugin registration [superset]

Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila commented on PR #26379:
URL: https://github.com/apache/superset/pull/26379#issuecomment-3224089160

   > There are only 2 places in master calling `setupPlugins()`:
   > 
   > [src/views/App.tsx](https://github.com/apache/superset/blob/48699a71946fd5981dba1f6d2cfabd0315137889/superset-frontend/src/views/App.tsx#L46) [src/embedded/index.tsx](https://github.com/apache/superset/blob/48699a71946fd5981dba1f6d2cfabd0315137889/superset-frontend/src/embedded/index.tsx#L48)
   > 
   > @Vitor-Avila @rusackas You might want to check if this call is required for Embedded.
   
   @rusackas are you aware if that's necessary? I'm not sure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org