You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 19:19:53 UTC
[GitHub] [arrow] pitrou commented on a change in pull request #8362: ARROW-10196: [C++] Add Future::DeferNotOk
pitrou commented on a change in pull request #8362:
URL: https://github.com/apache/arrow/pull/8362#discussion_r500539248
##########
File path: cpp/src/arrow/util/future.h
##########
@@ -358,6 +357,13 @@ class Future {
return fut;
}
+ static Future DeferNotOk(Result<Future> maybe_future) {
Review comment:
Can you add a docstring?
##########
File path: cpp/src/arrow/util/future.h
##########
@@ -154,9 +154,8 @@ class FutureStorage : public FutureStorageBase {
Status status() const { return result_.status(); }
- template <typename U>
- void MarkFinished(U&& value) {
- result_ = std::forward<U>(value);
+ void MarkFinished(Result<T> result) {
Review comment:
Does this implicitly convert from any T-convertible U?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org