[jira] [Commented] (CASSANDRA-13976) introduce max_hint_window_in_min, deprecate max_hint_window_in_ms

["Kirk True (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246835#comment-16246835 ] 

Kirk True commented on CASSANDRA-13976:
---------------------------------------

After thinking about this a little bit, it would seem that we need to support both {{max_hint_window_in_ms}} and {{max_hint_window_in_min}} everywhere. We would need to add:

# {{max_hint_window_in_min}} to {{Config}}
# {{getMaxHintWindowInMin}}/{{setMaxHintWindowInMin}} methods in {{DatabaseDescriptor}}, {{NodeProbe}}, {{StorageProxy}}, {{StorageProxyMBean}}, etc.
# A new {{GetMaxHintWindowInMin}} class to match {{GetMaxHintWindow}} to get the value via {{nodetool}}
# A new {{SetMaxHintWindowInMin}} class to match {{SetMaxHintWindow}} to set the value via {{nodetool}}

There would need to be a decision about which of {{max_hint_window_in_ms}} or {{max_hint_window_in_min}} to actually use internally. Regardless of whichever unit we used internally we'd likely have to convert from and to the other unit to maintain a coherent interface. For example, if we used minutes internally, the {{shouldHint}} method in {{StorageProxy}} would need to convert back to milliseconds from minutes anyway. Also, we'd need to convert back and forth for users of JMX and {{nodetool}}.

I'm not trying to argue that it's not a good change, I'm just wondering how to do it in a way that doesn't introduce complexity and confusion for end users and developers.

> introduce max_hint_window_in_min, deprecate max_hint_window_in_ms
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-13976
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13976
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jon Haddad
>            Assignee: Kirk True
>            Priority: Minor
>              Labels: lhf
>             Fix For: 4.0
>
>
> Milliseconds is unnecessarily precise.  At most, minutes would be used.  Config in 4.0 should default to a minute granularity, but if the max_hint_window_in_min isn't set should fall back on max_hint_window_in_ms and emit a warning.
> max_hint_window_in_min: 180 # new default, still at 3 hours.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org