You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mingyen066 (via GitHub)" <gi...@apache.org> on 2024/10/10 15:41:35 UTC
[PR] KAFKA-17693: Remove testEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion [kafka]
mingyen066 opened a new pull request, #17456:
URL: https://github.com/apache/kafka/pull/17456
Remove `testEarliestLocalTimestampVersion` and `testCheckLatestTieredTimestampVersion`
The ticket description mentioned that `testListOffsetsRequestOldestVersion` should be moved to the Java `ListOffsetRequestTest`, but it was already completed in [#17100](https://github.com/apache/kafka/pull/17100)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17693: Remove testEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17456:
URL: https://github.com/apache/kafka/pull/17456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17693: Remove testEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion [kafka]
Posted by "mingyen066 (via GitHub)" <gi...@apache.org>.
mingyen066 commented on PR #17456:
URL: https://github.com/apache/kafka/pull/17456#issuecomment-2411365431
@chia7712 Of course, the variable `versionInfo` has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17693: Remove testEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #17456:
URL: https://github.com/apache/kafka/pull/17456#discussion_r1795725213
##########
clients/src/test/java/org/apache/kafka/common/requests/ListOffsetsRequestTest.java:
##########
@@ -155,22 +155,6 @@ public void testToListOffsetsTopics() {
assertTrue(topic.partitions().contains(lop1));
}
- @Test
- public void testCheckEarliestLocalTimestampVersion() {
- int maxVersion = ApiKeys.LIST_OFFSETS.latestVersion();
- for (int i = 0; i <= maxVersion; i++) {
- testUnsupportedVersion(i, EARLIEST_LOCAL_TIMESTAMP);
- }
- }
-
- @Test
- public void testCheckLatestTieredTimestampVersion() {
- int maxVersion = ApiKeys.LIST_OFFSETS.latestVersion();
- for (int i = 0; i <= maxVersion; i++) {
- testUnsupportedVersion(i, LATEST_TIERED_TIMESTAMP);
- }
- }
-
private void testUnsupportedVersion(int version, long timestamp) {
Review Comment:
This helper method is unused after removing the tests. Please remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org