[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #3958: Implement right semi join and support in HashBuildProbeorder

[GitBox <gi...@apache.org>]

Dandandan commented on code in PR #3958:
URL: https://github.com/apache/arrow-datafusion/pull/3958#discussion_r1004675522


##########
datafusion/core/src/physical_optimizer/hash_build_probe_order.rs:
##########
@@ -70,8 +70,13 @@ fn should_swap_join_order(left: &dyn ExecutionPlan, right: &dyn ExecutionPlan) -
 
 fn supports_swap(join_type: JoinType) -> bool {
     match join_type {
-        JoinType::Inner | JoinType::Left | JoinType::Right | JoinType::Full => true,
-        JoinType::Semi | JoinType::Anti => false,
+        JoinType::Inner
+        | JoinType::Left
+        | JoinType::Right
+        | JoinType::Full
+        | JoinType::Semi

Review Comment:
   That might be better for clarity, but also a breaking change.
   I think we also should change Anti to LeftAnti if we want to do this.
   
   FYI @alamb @andygrove 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org