[jira] [Commented] (ORC-281) Fix compiler warnings from clang 5.0

["Owen O'Malley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354614#comment-16354614 ] 

Owen O'Malley commented on ORC-281:
-----------------------------------

I've included a subset of this patch in to ORC 1.4.3 that just changes the .travis-ci file to use clang 4.0 instead of clang 5.0.

> Fix compiler warnings from clang 5.0
> ------------------------------------
>
>                 Key: ORC-281
>                 URL: https://issues.apache.org/jira/browse/ORC-281
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We're currently getting:
> {code}
> [ 43%] Building CXX object c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o
> In file included from /home/travis/build/apache/orc/c++/src/io/InputStream.cc:20:
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:75:13: error: '~SeekableArrayInputStream' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override]
>     virtual ~SeekableArrayInputStream();
>             ^
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:53:13: note: overridden virtual function is here
>     virtual ~SeekableInputStream();
>             ^
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:104:13: error: '~SeekableFileInputStream' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override]
>     virtual ~SeekableFileInputStream();
>             ^
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:53:13: note: overridden virtual function is here
>     virtual ~SeekableInputStream();
>             ^
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)