You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/04/27 01:42:30 UTC

[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1099: ORC-1159: [C++] Fix crash when the last stripe is skipped

dongjoon-hyun commented on code in PR #1099:
URL: https://github.com/apache/orc/pull/1099#discussion_r859303177


##########
c++/test/TestPredicatePushdown.cc:
##########
@@ -281,6 +282,45 @@ namespace orc {
     for (uint64_t i = 0; i < 2000; ++i) {
       EXPECT_EQ(i + 3500 , batch1.data[i]);
     }
+    // 2nd batch of 1500 rows

Review Comment:
   Please make a new test case, @stiga-huang .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org