You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2020/08/16 10:52:50 UTC

svn commit: r1880891 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java

Author: lehmi
Date: Sun Aug 16 10:52:50 2020
New Revision: 1880891

URL: http://svn.apache.org/viewvc?rev=1880891&view=rev
Log:
PDFBOX-4836: remove Cloneable interface

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java?rev=1880891&r1=1880890&r2=1880891&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/io/RandomAccessReadBuffer.java Sun Aug 16 10:52:50 2020
@@ -26,7 +26,7 @@ import java.util.List;
  * An implementation of the RandomAccessRead interface to store data in memory. The data will be stored in chunks
  * organized in an ArrayList.
  */
-public class RandomAccessReadBuffer implements RandomAccessRead, Cloneable
+public class RandomAccessReadBuffer implements RandomAccessRead
 {
     // default chunk size is 4kb
     private static final int DEFAULT_CHUNK_SIZE_4KB = 1 << 12;
@@ -131,38 +131,6 @@ public class RandomAccessReadBuffer impl
         
     }
 
-    @Override
-    public RandomAccessReadBuffer clone()
-    {
-        RandomAccessReadBuffer copy = new RandomAccessReadBuffer(chunkSize);
-
-        copy.bufferList = new ArrayList<>(bufferList.size());
-        for (ByteBuffer buffer : bufferList)
-        {
-            ByteBuffer newBuffer = ByteBuffer.allocate(buffer.limit());
-            int originPosition = buffer.position();
-            buffer.rewind();
-            newBuffer.put(buffer);
-            copy.bufferList.add(newBuffer);
-            buffer.position(originPosition);
-        }
-        if (currentBuffer != null)
-        {
-            copy.currentBuffer = copy.bufferList.get(copy.bufferList.size() - 1);
-        }
-        else
-        {
-            copy.currentBuffer = null;
-        }
-        copy.pointer = pointer;
-        copy.currentBufferPointer = currentBufferPointer;
-        copy.size = size;
-        copy.bufferListIndex = bufferListIndex;
-        copy.bufferListMaxIndex = bufferListMaxIndex;
-
-        return copy;
-    }
-
     /**
      * {@inheritDoc}
      */