You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/08/24 11:28:55 UTC
[PR] fix(runtime): add the missing ASF headers to the plugin modules [maka]
Astro-Han opened a new pull request, #3708:
URL: https://github.com/apache/maka/pull/3708
`Check ASF source headers` is failing on `main`, so `main` and every branch built on it currently report a red CI run for a reason unrelated to their own changes.
Five files added by #3250 carry no license header:
```
packages/runtime/src/plugin-kernel.ts
packages/runtime/src/plugin-runtime.ts
packages/runtime/src/plugin-composition-loader.ts
packages/runtime/src/__tests__/plugin-kernel.test.ts
packages/runtime/src/__tests__/plugin-composition-loader.test.ts
```
#3250's own commit was already red for this, so the failure arrived with that merge rather than with anything after it.
This change is the output of `node scripts/asf-license-headers.mjs write` and nothing else — the standard header the script emits, added to those five files, `+95` lines and no logic change. After it, `node scripts/asf-license-headers.mjs check` reports all 2819 covered files clean, which I verified on a clean checkout of current `main`.
@likun666661 — you own #3250, so if you would rather land this yourself, please say so and I will close this. I opened it because `main` being red makes every other PR's CI harder to read, and this seemed worth unblocking quickly rather than waiting.
<details><summary>简体中文</summary>
`main` 上的 `Check ASF source headers` 正在失败，因此 `main` 以及所有基于它的分支，当前都会因为与自身改动无关的原因报出一次红色 CI。
#3250 新增的五个文件没有版权头：
```
packages/runtime/src/plugin-kernel.ts
packages/runtime/src/plugin-runtime.ts
packages/runtime/src/plugin-composition-loader.ts
packages/runtime/src/__tests__/plugin-kernel.test.ts
packages/runtime/src/__tests__/plugin-composition-loader.test.ts
```
#3250 自己那个提交上的 CI 就已经是红的，所以这个失败是随那次合并到来的，不是之后的改动引入的。
本次改动就是 `node scripts/asf-license-headers.mjs write` 的输出，除此之外没有别的内容——把脚本生成的标准版权头加到这五个文件上，`+95` 行，零逻辑改动。之后 `node scripts/asf-license-headers.mjs check` 报告 2819 个受覆盖文件全部通过，我在当前 `main` 的干净检出上验证过。
@likun666661 —— #3250 是你的，如果你更希望自己来修，说一声我就把这个关掉。我开这个 PR 是因为 `main` 红着会让其他所有 PR 的 CI 结果难以判读，觉得值得尽快解开，而不是等。
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(runtime): add the missing ASF headers to the plugin modules [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #3708:
URL: https://github.com/apache/maka/pull/3708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(runtime): add the missing ASF headers to the plugin modules [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #3708:
URL: https://github.com/apache/maka/pull/3708#issuecomment-5394751597
LGTM. The diff adds only the standard 19-line ASF license header to five files; with those lines removed the bodies are byte-identical to the base. `test` is green on the current head. Merging to unblock `main`.
<details>
<summary>简体中文</summary>
已确认。这个 diff 只是给五个文件加上标准的 19 行 ASF license header，去掉这些行后正文与 base 逐字节一致。当前 head 上 `test` 已通过。合并以恢复 `main`。
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org