You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Maja Kabiljo (JIRA)" <ji...@apache.org> on 2012/09/14 00:07:08 UTC
[jira] [Created] (GIRAPH-325) A few more progress calls
Maja Kabiljo created GIRAPH-325:
-----------------------------------
Summary: A few more progress calls
Key: GIRAPH-325
URL: https://issues.apache.org/jira/browse/GIRAPH-325
Project: Giraph
Issue Type: Improvement
Reporter: Maja Kabiljo
Priority: Minor
Attachments: GIRAPH-325.patch
(Posting issue and the patch from a colleague)
Call progress on a few more places.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (GIRAPH-325) A few more progress calls
Posted by Eli Reisman <ap...@gmail.com>.
+1 from me.
On Mon, Oct 1, 2012 at 10:29 PM, Avery Ching (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/GIRAPH-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467494#comment-13467494]
>
> Avery Ching commented on GIRAPH-325:
> ------------------------------------
>
> +1
>
> > A few more progress calls
> > -------------------------
> >
> > Key: GIRAPH-325
> > URL: https://issues.apache.org/jira/browse/GIRAPH-325
> > Project: Giraph
> > Issue Type: Improvement
> > Reporter: Maja Kabiljo
> > Priority: Minor
> > Attachments: GIRAPH-325.patch, GIRAPH-325.patch
> >
> >
> > (Posting issue and the patch from a colleague)
> > Call progress on a few more places.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
[jira] [Commented] (GIRAPH-325) A few more progress calls
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467494#comment-13467494 ]
Avery Ching commented on GIRAPH-325:
------------------------------------
+1
> A few more progress calls
> -------------------------
>
> Key: GIRAPH-325
> URL: https://issues.apache.org/jira/browse/GIRAPH-325
> Project: Giraph
> Issue Type: Improvement
> Reporter: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-325.patch, GIRAPH-325.patch
>
>
> (Posting issue and the patch from a colleague)
> Call progress on a few more places.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-325) One more progress call
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468294#comment-13468294 ]
Hudson commented on GIRAPH-325:
-------------------------------
Integrated in Giraph-trunk-Commit #218 (See [https://builds.apache.org/job/Giraph-trunk-Commit/218/])
GIRAPH-325: One more progress call. (majakabiljo via aching) (Revision 1393268)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1393268
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/src/main/java/org/apache/giraph/graph/MasterThread.java
> One more progress call
> ----------------------
>
> Key: GIRAPH-325
> URL: https://issues.apache.org/jira/browse/GIRAPH-325
> Project: Giraph
> Issue Type: Improvement
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-325.patch, GIRAPH-325.patch
>
>
> (Posting issue and the patch from a colleague)
> Call progress on a few more places.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-325) One more progress call
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-325:
-------------------------------
Summary: One more progress call (was: A few more progress calls)
> One more progress call
> ----------------------
>
> Key: GIRAPH-325
> URL: https://issues.apache.org/jira/browse/GIRAPH-325
> Project: Giraph
> Issue Type: Improvement
> Reporter: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-325.patch, GIRAPH-325.patch
>
>
> (Posting issue and the patch from a colleague)
> Call progress on a few more places.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-325) A few more progress calls
Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maja Kabiljo updated GIRAPH-325:
--------------------------------
Attachment: GIRAPH-325.patch
I see most of these were added with the final patch for GIRAPH-274, just the one from MasterThread left.
> A few more progress calls
> -------------------------
>
> Key: GIRAPH-325
> URL: https://issues.apache.org/jira/browse/GIRAPH-325
> Project: Giraph
> Issue Type: Improvement
> Reporter: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-325.patch, GIRAPH-325.patch
>
>
> (Posting issue and the patch from a colleague)
> Call progress on a few more places.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-325) A few more progress calls
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455402#comment-13455402 ]
Eli Reisman commented on GIRAPH-325:
------------------------------------
Interesting idea here for sure, but I don't think you can replace the write() signature in a Writable without breaking Giraph's interaction with that class of Writables.
But...adding more progress() calls where loops of these Writables are written/read is a good idea if you know each one is large and will take a while. I do think unless each instance you are protecting takes longer than 30 seconds to load you're very safe calling progress() in between serializations of single objects rather than during the serialization calls.
There are also other places where Giraph does not call progress() often enough to please Hadoop, see GIRAPH-274.
> A few more progress calls
> -------------------------
>
> Key: GIRAPH-325
> URL: https://issues.apache.org/jira/browse/GIRAPH-325
> Project: Giraph
> Issue Type: Improvement
> Reporter: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-325.patch
>
>
> (Posting issue and the patch from a colleague)
> Call progress on a few more places.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-325) A few more progress calls
Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maja Kabiljo updated GIRAPH-325:
--------------------------------
Attachment: GIRAPH-325.patch
> A few more progress calls
> -------------------------
>
> Key: GIRAPH-325
> URL: https://issues.apache.org/jira/browse/GIRAPH-325
> Project: Giraph
> Issue Type: Improvement
> Reporter: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-325.patch
>
>
> (Posting issue and the patch from a colleague)
> Call progress on a few more places.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira