You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2022/02/17 21:36:12 UTC
[kudu-CR] [security] harmonize updates to mini kdc
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18245
Change subject: [security] harmonize updates to mini_kdc
......................................................................
[security] harmonize updates to mini_kdc
Impala recently rebased their Kudu libraries and ran into some build
issues. This patch addresses one:
An Impala backend test calls MiniKdc::Kinit() with parameter
"dummy/host", but "/" caused a runtime error in MiniKdc::Kinit(). This
patch replaces "/" with "_" when creating the template. The same is not
done for principal names, which can consist "/".
This is a follow-up to 8133fbfb734c18be8f4abb3ee83ac9dd0cc4ce16.
Change-Id: I60bd9a0bf3113a689a252182b4e6292dff12a9e7
---
M src/kudu/security/test/mini_kdc.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/18245/1
--
To view, visit http://gerrit.cloudera.org:8080/18245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60bd9a0bf3113a689a252182b4e6292dff12a9e7
Gerrit-Change-Number: 18245
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] [security] harmonize updates to mini kdc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18245 )
Change subject: [security] harmonize updates to mini_kdc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60bd9a0bf3113a689a252182b4e6292dff12a9e7
Gerrit-Change-Number: 18245
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Feb 2022 00:23:46 +0000
Gerrit-HasComments: No
[kudu-CR] [security] harmonize updates to mini kdc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18245 )
Change subject: [security] harmonize updates to mini_kdc
......................................................................
[security] harmonize updates to mini_kdc
Impala recently rebased their Kudu libraries and ran into some build
issues. This patch addresses one:
An Impala backend test calls MiniKdc::Kinit() with parameter
"dummy/host", but "/" caused a runtime error in MiniKdc::Kinit(). This
patch replaces "/" with "_" when creating the template. The same is not
done for principal names, which can consist "/".
This is a follow-up to 8133fbfb734c18be8f4abb3ee83ac9dd0cc4ce16.
Change-Id: I60bd9a0bf3113a689a252182b4e6292dff12a9e7
Reviewed-on: http://gerrit.cloudera.org:8080/18245
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/security/test/mini_kdc.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I60bd9a0bf3113a689a252182b4e6292dff12a9e7
Gerrit-Change-Number: 18245
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] harmonize updates to mini kdc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18245 )
Change subject: [security] harmonize updates to mini_kdc
......................................................................
Patch Set 1:
Thank you for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/18245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60bd9a0bf3113a689a252182b4e6292dff12a9e7
Gerrit-Change-Number: 18245
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Feb 2022 00:24:04 +0000
Gerrit-HasComments: No