You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/07/28 04:41:52 UTC
[GitHub] [avro] complone commented on a diff in pull request #1790: [AVRO-3590] fix Snappy CodecFactory is null
complone commented on code in PR #1790:
URL: https://github.com/apache/avro/pull/1790#discussion_r931775163
##########
lang/java/avro/src/main/java/org/apache/avro/file/SnappyCodec.java:
##########
@@ -37,7 +40,7 @@ static class Option extends CodecFactory {
@Override
protected Codec createInstance() {
- return new SnappyCodec();
+ return SnappyCodec.INSTANCE;
Review Comment:
For related descriptions, see:
https://issues.apache.org/jira/browse/AVRO-3590
##########
lang/java/avro/src/main/java/org/apache/avro/file/SnappyCodec.java:
##########
@@ -37,7 +40,7 @@ static class Option extends CodecFactory {
@Override
protected Codec createInstance() {
- return new SnappyCodec();
+ return SnappyCodec.INSTANCE;
Review Comment:
@clesaec For related descriptions, see:
https://issues.apache.org/jira/browse/AVRO-3590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org