You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Arnaud Vandyck <ar...@ulg.ac.be> on 2003/05/30 10:13:01 UTC

[fileupload] [proposal] lib property in build.xml

Hi all,

I  am  working  on  packaging  fileupload to  Debian.  Because  of  some
requierments in Debian, I have to specify the CLASSPATH my self (or tell
to  ant where  it is).  But I  do  not have  any lib  directory, so  ant
craches.  I've  been  obliged   to  comment  the  additionnal  classpath
information in the javac task. 

My  proposal is  to  change the  reference  to the  lib  directory to  a
reference to a property so I can override it from my ant call. 

Thanks for your time,

-- Arnaud Vandyck, STE fi, ULg


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [fileupload] [proposal] lib property in build.xml

Posted by Arnaud Vandyck <ar...@ulg.ac.be>.
Martin Cooper <ma...@apache.org> wrote:
,----
| That should not  be a problem.  If you look  at the 'get-deps' target,
| you'll see that it has an  'unless' attribute, so that you can prevent
| it from trying to connect to  ibiblio. As long as the dependencies are
| already available locally, you'll be fine.
`----

I saw that, it's well done!

,----
| Note that I  have just regenerated the Ant build  file using Maven b9,
| and the  structure is a bit  different to what was  there before.  You
| might want to take a look at  the new version and see if it meets your
| needs.
`----

I saw  your commit and will  have a look at  it. I'll let  you know what
happens ;-)

-- Arnaud Vandyck, STE fi, ULg
   Formateur Cellule Programmation.

Re: [fileupload] [proposal] lib property in build.xml

Posted by Martin Cooper <ma...@apache.org>.

On Tue, 3 Jun 2003, Arnaud Vandyck wrote:

> Martin Cooper <ma...@apache.org> wrote:
> > > My proposal  is to change  the reference to  the lib directory  to a
> > > reference to a property so I can override it from my ant call.
> >
> > The problem is that build.xml for FileUpload is generated by Maven, so
> > any change to it will be overwritten the next time it is generated.
>
> I don't know your internals very well.
>
> > I  don't really  understand what  the requirement  is for  Debian. You
> > mention the  classpath, but  I don't  see how that  is related  to the
> > 'lib' value in the build file.  Could you explain in more detail? Then
> > perhaps we can find an alternative way of solving the problem.
>
> 1°  It is  not  acceptable that  a  Debian package  require an  internet
>    connection to be build (they are all built from source and have to be
>    built by  anyone who respect  the dependencies!).  It must  depend on
>    other  packages  and  when  installed,  it  has  to  compile  without
>    problem. So impossible to go to ibiblio!

That should not be a problem. If you look at the 'get-deps' target, you'll
see that it has an 'unless' attribute, so that you can prevent it from
trying to connect to ibiblio. As long as the dependencies are already
available locally, you'll be fine.

>
> 2° I got some troubles with  my jdk (j2sdk 1.3 from Blackdown[1]) if the
>    directory 'lib' is  in the classpath but does  not exist. Maybe there
>    is a work around.
>
> 3° I have  to define the classpath by hand whereas  there is a directory
>    containing all the installed jars[2].

Note that I have just regenerated the Ant build file using Maven b9, and
the structure is a bit different to what was there before. You might want
to take a look at the new version and see if it meets your needs.

--
Martin Cooper


>
> Thanks for your help,
>
> Footnotes:
> [1] http://blackdown.org
>
> [2] /usr/share/java/*.jar
>
> -- Arnaud Vandyck, STE fi, ULg
>    Formateur Cellule Programmation.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [fileupload] [proposal] lib property in build.xml

Posted by Arnaud Vandyck <ar...@ulg.ac.be>.
Martin Cooper <ma...@apache.org> wrote:
> > My proposal  is to change  the reference to  the lib directory  to a
> > reference to a property so I can override it from my ant call.
> 
> The problem is that build.xml for FileUpload is generated by Maven, so
> any change to it will be overwritten the next time it is generated.

I don't know your internals very well.

> I  don't really  understand what  the requirement  is for  Debian. You
> mention the  classpath, but  I don't  see how that  is related  to the
> 'lib' value in the build file.  Could you explain in more detail? Then
> perhaps we can find an alternative way of solving the problem.

1°  It is  not  acceptable that  a  Debian package  require an  internet
   connection to be build (they are all built from source and have to be
   built by  anyone who respect  the dependencies!).  It must  depend on
   other  packages  and  when  installed,  it  has  to  compile  without
   problem. So impossible to go to ibiblio!

2° I got some troubles with  my jdk (j2sdk 1.3 from Blackdown[1]) if the
   directory 'lib' is  in the classpath but does  not exist. Maybe there
   is a work around. 

3° I have  to define the classpath by hand whereas  there is a directory
   containing all the installed jars[2]. 

Thanks for your help,

Footnotes: 
[1] http://blackdown.org

[2] /usr/share/java/*.jar

-- Arnaud Vandyck, STE fi, ULg
   Formateur Cellule Programmation.

Re: [fileupload] [proposal] lib property in build.xml

Posted by Martin Cooper <ma...@apache.org>.

On Fri, 30 May 2003, Arnaud Vandyck wrote:

> Hi all,
>
> I  am  working  on  packaging  fileupload to  Debian.  Because  of  some
> requierments in Debian, I have to specify the CLASSPATH my self (or tell
> to  ant where  it is).  But I  do  not have  any lib  directory, so  ant
> craches.  I've  been  obliged   to  comment  the  additionnal  classpath
> information in the javac task.
>
> My  proposal is  to  change the  reference  to the  lib  directory to  a
> reference to a property so I can override it from my ant call.

The problem is that build.xml for FileUpload is generated by Maven, so any
change to it will be overwritten the next time it is generated.

I don't really understand what the requirement is for Debian. You mention
the classpath, but I don't see how that is related to the 'lib' value in
the build file. Could you explain in more detail? Then perhaps we can find
an alternative way of solving the problem.

--
Martin Cooper


>
> Thanks for your time,
>
> -- Arnaud Vandyck, STE fi, ULg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [patch] [fileupload] [proposal] lib property in build.xml

Posted by Arnaud Vandyck <Ar...@ulg.ac.be>.
<citation de="John McNally">
> Is there any reason you are only changing one use of the lib
> directory?

absent-minded :-p

I now replaced all the occurences.

-- 
arnaud @ somewhere


Re: [patch] [fileupload] [proposal] lib property in build.xml

Posted by John McNally <jm...@collab.net>.
Is there any reason you are only changing one use of the lib directory? 
john mcnally

On Sun, 2003-06-01 at 14:13, Arnaud Vandyck wrote:
> robert burrell donkin <ro...@blueyonder.co.uk> wrote:
> > that  sounds  fine.  please  supply  a patch  against  CVS  HEAD  (see
> > http://jakarta.apache.org/commons/patches.html for more details).
> 
> done ;-)
> 
> > On Friday, May 30, 2003, at 09:13 AM, Arnaud Vandyck wrote:
> > 
> > > Hi all,
> > >
> > > I am  working on  packaging fileupload to  Debian.  Because  of some
> > > requierments in Debian, I have  to specify the CLASSPATH my self (or
> > > tell to ant where  it is).  But I do not have  any lib directory, so
> > > ant craches.  I've been obliged to comment the additionnal classpath
> > > information in the javac task.
> > >
> > > My proposal  is to change  the reference to  the lib directory  to a
> > > reference to a property so I can override it from my ant call.
> > >
> > > Thanks for your time,
> 
> -- Arnaud Vandyck, STE fi, ULg
> ----
> 

> Index: build.xml
> ===================================================================
> RCS file: /home/cvspublic/jakarta-commons/fileupload/build.xml,v
> retrieving revision 1.5
> diff -u -r1.5 build.xml
> --- build.xml	27 Oct 2002 18:47:51 -0000	1.5
> +++ build.xml	1 Jun 2003 21:10:03 -0000
> @@ -9,6 +9,7 @@
>    <property name="distdir" value="dist"></property>
>    <property name="javadocdir" value="target/docs/apidocs"></property>
>    <property name="final.name" value="commons-fileupload-1.0-dev"></property>
> +  <property name="lib" value="lib"></property>
>  
>    <!-- The test runner to execute -->
>    <property name="test.runner"             value="junit.textui.TestRunner"/>
> @@ -34,7 +35,7 @@
>          <pathelement location="src/java"></pathelement>
>        </src>
>        <classpath>
> -        <fileset dir="lib">
> +        <fileset dir="${lib}">
>            <include name="*.jar"></include>
>          </fileset>
>        </classpath>
> 
> ----
> 

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[patch] [fileupload] [proposal] lib property in build.xml

Posted by Arnaud Vandyck <ar...@ulg.ac.be>.
robert burrell donkin <ro...@blueyonder.co.uk> wrote:
> that  sounds  fine.  please  supply  a patch  against  CVS  HEAD  (see
> http://jakarta.apache.org/commons/patches.html for more details).

done ;-)

> On Friday, May 30, 2003, at 09:13 AM, Arnaud Vandyck wrote:
> 
> > Hi all,
> >
> > I am  working on  packaging fileupload to  Debian.  Because  of some
> > requierments in Debian, I have  to specify the CLASSPATH my self (or
> > tell to ant where  it is).  But I do not have  any lib directory, so
> > ant craches.  I've been obliged to comment the additionnal classpath
> > information in the javac task.
> >
> > My proposal  is to change  the reference to  the lib directory  to a
> > reference to a property so I can override it from my ant call.
> >
> > Thanks for your time,

-- Arnaud Vandyck, STE fi, ULg

Re: [fileupload] [proposal] lib property in build.xml

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
that sounds fine. please supply a patch against CVS HEAD (see http://http:
//jakarta.apache.org/commons/patches.html for more details).

- robert

On Friday, May 30, 2003, at 09:13 AM, Arnaud Vandyck wrote:

> Hi all,
>
> I  am  working  on  packaging  fileupload to  Debian.  Because  of  some
> requierments in Debian, I have to specify the CLASSPATH my self (or tell
> to  ant where  it is).  But I  do  not have  any lib  directory, so  ant
> craches.  I've  been  obliged   to  comment  the  additionnal  classpath
> information in the javac task.
>
> My  proposal is  to  change the  reference  to the  lib  directory to  a
> reference to a property so I can override it from my ant call.
>
> Thanks for your time,
>
> -- Arnaud Vandyck, STE fi, ULg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org