You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "mkolesnikov (via GitHub)" <gi...@apache.org> on 2023/12/01 13:08:58 UTC

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

mkolesnikov commented on code in PR #202:
URL: https://github.com/apache/maven-release/pull/202#discussion_r1412084550


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForReleasePhase.java:
##########
@@ -214,6 +217,15 @@ private boolean translateScm(
         return result;
     }
 
+    @Override

Review Comment:
   That one I missed and forgot to revert. It was part of the spontaneous refactoring, the goal is to make Abstract classes to be abstract as they intended to be by their names, then to combine CI Friendly logic in one place, but the code is more coupled then I thought. So I gave up on it for now. Maybe someday I'll complete it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org