You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/06/20 01:53:24 UTC
[GitHub] spark pull request #21595: [MINOR][SQL] Remove invalid comment from SparkStr...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/spark/pull/21595
[MINOR][SQL] Remove invalid comment from SparkStrategies
## What changes were proposed in this pull request?
This patch is removing invalid comment from SparkStrategies, given that TODO-like comment is no longer preferred one as the comment: https://github.com/apache/spark/pull/21388#issuecomment-396856235
Removing invalid comment will prevent contributors to spend their times which is not going to be merged.
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/spark MINOR-remove-invalid-comment-on-spark-strategies
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21595.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21595
----
commit 8afb36b20aab1bbd1f6a5cf902aef7e0c04c8353
Author: Jungtaek Lim <ka...@...>
Date: 2018-06-20T01:48:17Z
[MINOR][SQL] Remove invalid comment from SparkStrategies
* The option is no longer preferred one as below comment
* https://github.com/apache/spark/pull/21388#issuecomment-396856235
* Removing this to prevent contributors to waste their times
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21595: [MINOR][SQL] Remove invalid comment from SparkStr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21595
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21595: [MINOR][SQL] Remove invalid comment from SparkStrategies
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21595
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21595: [MINOR][SQL] Remove invalid comment from SparkStrategies
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21595
LGTM - merging to master. Thanks
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21595: [MINOR][SQL] Remove invalid comment from SparkStrategies
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21595
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92111/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21595: [MINOR][SQL] Remove invalid comment from SparkStrategies
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21595
@HyukjinKwon @hvanhovell Thanks for reviewing and merging!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21595: [MINOR][SQL] Remove invalid comment from SparkStrategies
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21595
**[Test build #92111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92111/testReport)** for PR 21595 at commit [`8afb36b`](https://github.com/apache/spark/commit/8afb36b20aab1bbd1f6a5cf902aef7e0c04c8353).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21595: [MINOR][SQL] Remove invalid comment from SparkStrategies
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21595
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21595: [MINOR][SQL] Remove invalid comment from SparkStrategies
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21595
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21595: [MINOR][SQL] Remove invalid comment from SparkStrategies
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21595
**[Test build #92111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92111/testReport)** for PR 21595 at commit [`8afb36b`](https://github.com/apache/spark/commit/8afb36b20aab1bbd1f6a5cf902aef7e0c04c8353).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org