You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/25 06:37:44 UTC

[GitHub] [incubator-dolphinscheduler] Yeleights opened a new pull request #1568: #747 Worker Log desensitization(日志脱敏)

Yeleights opened a new pull request #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568
 
 
   ## What is the purpose of the pull request
   *#747 Worker Data Source Log Desensitization*
   
   ## Brief change log
     - *Add DATASOURCE_PASSWORD_REGEX to Constants*
     - *Add SensitiveLogUtil, SensitiveDataConverter, SensitiveLogUtilTest, SensitiveDataConverterTest*
     - *Add conversionRule to worker_logback.xml*
   ## Verify this pull request
   This change added tests and can be verified as follows:
     - *Added SensitiveLogUtilTest and SensitiveDataConverterTest to verify the change.*
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1568: #747 Worker Log desensitization(日志脱敏)

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568#discussion_r361304169
 
 

 ##########
 File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/log/SensitiveDataConverter.java
 ##########
 @@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.server.worker.log;
+
+
+import ch.qos.logback.classic.pattern.MessageConverter;
+import ch.qos.logback.classic.spi.ILoggingEvent;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.server.utils.SensitiveLogUtil;
+
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+/**
+ * sensitive data log converter
+ */
+@Slf4j
+public class SensitiveDataConverter extends MessageConverter {
+
+
+    @Override
+    public String convert(ILoggingEvent event) {
+
+        // get original log
+        String requestLogMsg = event.getFormattedMessage();
+
+        // desensitization log
+        return convertMsg(requestLogMsg);
+    }
+
+    /**
+     * deal with sensitive log
+     *
+     * @param oriLogMsg original log
+     */
+    private String convertMsg(final String oriLogMsg) {
+
+        String tempLogMsg = oriLogMsg;
+
+        if (StringUtils.isNotEmpty(tempLogMsg)) {
+            tempLogMsg = passwordHandler(tempLogMsg);
+        }
+        return tempLogMsg;
+    }
+
+    /**
+     * password regex
+     *
+     * @param logMsg original log
+     */
+    private String passwordHandler(String logMsg) {
+
+        Pattern pattern = Pattern.compile(Constants.DATASOURCE_PASSWORD_REGEX);
 
 Review comment:
   put this line as private object

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1568: #747 Worker Log desensitization(日志脱敏)

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568#issuecomment-568850902
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=h1) Report
   > Merging [#1568](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1568      +/-   ##
   ========================================
   - Coverage   7.58%   7.57%   -0.02%     
   ========================================
     Files        277     279       +2     
     Lines      13743   13764      +21     
     Branches    2194    2197       +3     
   ========================================
     Hits        1043    1043              
   - Misses     12631   12652      +21     
     Partials      69      69
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | |
   | [...olphinscheduler/server/utils/SensitiveLogUtil.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWwuamF2YQ==) | `0% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=footer). Last update [026fdd9...ace4628](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] lenboo merged pull request #1568: #747 Worker Log desensitization(日志脱敏)

Posted by GitBox <gi...@apache.org>.
lenboo merged pull request #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1568: #747 Worker Log desensitization(日志脱敏)

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568#issuecomment-568850902
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=h1) Report
   > Merging [#1568](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1568      +/-   ##
   ========================================
   - Coverage   7.58%   7.57%   -0.02%     
   ========================================
     Files        277     279       +2     
     Lines      13743   13763      +20     
     Branches    2194    2197       +3     
   ========================================
     Hits        1043    1043              
   - Misses     12631   12651      +20     
     Partials      69      69
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | |
   | [...olphinscheduler/server/utils/SensitiveLogUtil.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWwuamF2YQ==) | `0% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=footer). Last update [026fdd9...c229c08](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1568: #747 Worker Log desensitization(日志脱敏)

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568#issuecomment-568850902
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=h1) Report
   > Merging [#1568](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/e4edf3e4d07a7a1acdf63cf8806ecbbe84e8e517?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1568      +/-   ##
   ========================================
   - Coverage   8.24%   8.23%   -0.02%     
   ========================================
     Files        281     283       +2     
     Lines      13822   13843      +21     
     Branches    2201    2204       +3     
   ========================================
     Hits        1140    1140              
   - Misses     12607   12628      +21     
     Partials      75      75
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | |
   | [...olphinscheduler/server/utils/SensitiveLogUtil.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWwuamF2YQ==) | `0% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=footer). Last update [e4edf3e...9ff900d](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Yeleights commented on a change in pull request #1568: #747 Worker Log desensitization(日志脱敏)

Posted by GitBox <gi...@apache.org>.
Yeleights commented on a change in pull request #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568#discussion_r361318149
 
 

 ##########
 File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/log/SensitiveDataConverter.java
 ##########
 @@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.server.worker.log;
+
+
+import ch.qos.logback.classic.pattern.MessageConverter;
+import ch.qos.logback.classic.spi.ILoggingEvent;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.server.utils.SensitiveLogUtil;
+
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+/**
+ * sensitive data log converter
+ */
+@Slf4j
+public class SensitiveDataConverter extends MessageConverter {
+
+
+    @Override
+    public String convert(ILoggingEvent event) {
+
+        // get original log
+        String requestLogMsg = event.getFormattedMessage();
+
+        // desensitization log
+        return convertMsg(requestLogMsg);
+    }
+
+    /**
+     * deal with sensitive log
+     *
+     * @param oriLogMsg original log
+     */
+    private String convertMsg(final String oriLogMsg) {
+
+        String tempLogMsg = oriLogMsg;
+
+        if (StringUtils.isNotEmpty(tempLogMsg)) {
+            tempLogMsg = passwordHandler(tempLogMsg);
+        }
+        return tempLogMsg;
+    }
+
+    /**
+     * password regex
+     *
+     * @param logMsg original log
+     */
+    private String passwordHandler(String logMsg) {
+
+        Pattern pattern = Pattern.compile(Constants.DATASOURCE_PASSWORD_REGEX);
 
 Review comment:
   thx, i will fix it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1568: #747 Worker Log desensitization(日志脱敏)

Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568#discussion_r361304456
 
 

 ##########
 File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/log/SensitiveDataConverter.java
 ##########
 @@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.server.worker.log;
+
+
+import ch.qos.logback.classic.pattern.MessageConverter;
+import ch.qos.logback.classic.spi.ILoggingEvent;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.dolphinscheduler.common.Constants;
+import org.apache.dolphinscheduler.server.utils.SensitiveLogUtil;
+
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+/**
+ * sensitive data log converter
+ */
+@Slf4j
+public class SensitiveDataConverter extends MessageConverter {
+
+
+    @Override
+    public String convert(ILoggingEvent event) {
+
+        // get original log
+        String requestLogMsg = event.getFormattedMessage();
+
+        // desensitization log
+        return convertMsg(requestLogMsg);
+    }
+
+    /**
+     * deal with sensitive log
+     *
+     * @param oriLogMsg original log
+     */
+    private String convertMsg(final String oriLogMsg) {
+
+        String tempLogMsg = oriLogMsg;
+
+        if (StringUtils.isNotEmpty(tempLogMsg)) {
+            tempLogMsg = passwordHandler(tempLogMsg);
+        }
+        return tempLogMsg;
+    }
+
+    /**
+     * password regex
+     *
+     * @param logMsg original log
+     */
+    private String passwordHandler(String logMsg) {
+
+        Pattern pattern = Pattern.compile(Constants.DATASOURCE_PASSWORD_REGEX);
+
+        Matcher matcher = pattern.matcher(logMsg);
+
+        StringBuffer sb = new StringBuffer();
 
 Review comment:
   StringBuffer sb = new StringBuffer(logMsg.length);

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1568: #747 Worker Log desensitization(日志脱敏)

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568#issuecomment-568850902
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=h1) Report
   > Merging [#1568](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/026fdd9e1c2fab944776c6cc09716d0b5b185baa?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1568      +/-   ##
   ========================================
   - Coverage   7.58%   7.57%   -0.02%     
   ========================================
     Files        277     279       +2     
     Lines      13743   13763      +20     
     Branches    2194    2197       +3     
   ========================================
     Hits        1043    1043              
   - Misses     12631   12651      +20     
     Partials      69      69
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
   | [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | |
   | [...olphinscheduler/server/utils/SensitiveLogUtil.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWwuamF2YQ==) | `0% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=footer). Last update [026fdd9...286768c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] lenboo commented on issue #1568: #747 Worker Log desensitization(日志脱敏)

Posted by GitBox <gi...@apache.org>.
lenboo commented on issue #1568: #747 Worker Log desensitization(日志脱敏)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1568#issuecomment-569036798
 
 
   @Yeleights please resolve the conflicts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services