You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/06 06:25:15 UTC
[GitHub] [geode] mivanac opened a new pull request, #7664: Newfeature2/geode 9484
mivanac opened a new pull request, #7664:
URL: https://github.com/apache/geode/pull/7664
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [*] Is your initial contribution a single, squashed commit?
- [*] Does `gradlew build` run cleanly?
- [*] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #7664: Newfeature2/geode 9484
Posted by GitBox <gi...@apache.org>.
mivanac commented on PR #7664:
URL: https://github.com/apache/geode/pull/7664#issuecomment-1149071563
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett
could you review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac merged pull request #7664: GEODE-9484: Improve sending message to multy destinations
Posted by GitBox <gi...@apache.org>.
mivanac merged PR #7664:
URL: https://github.com/apache/geode/pull/7664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #7664: Newfeature2/geode 9484
Posted by GitBox <gi...@apache.org>.
mivanac commented on PR #7664:
URL: https://github.com/apache/geode/pull/7664#issuecomment-1124104592
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett
could you review this PR.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #7664: Newfeature2/geode 9484
Posted by GitBox <gi...@apache.org>.
mivanac commented on PR #7664:
URL: https://github.com/apache/geode/pull/7664#issuecomment-1164325248
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett
could you review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on a diff in pull request #7664: GEODE-9484: Improve sending message to multy destinations
Posted by GitBox <gi...@apache.org>.
mivanac commented on code in PR #7664:
URL: https://github.com/apache/geode/pull/7664#discussion_r911633021
##########
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/UpdatePropagationDistributedTest.java:
##########
@@ -258,7 +309,7 @@ private Integer createServerCache() throws Exception {
server.setPort(port);
server.setNotifyBySubscription(true);
server.start();
- return server.getPort();
+ return new Integer(server.getPort());
Review Comment:
Thanks for comments. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #7664: Newfeature2/geode 9484
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on PR #7664:
URL: https://github.com/apache/geode/pull/7664#issuecomment-1168905264
This PR would probably get more notice with a properly formatted and descriptive title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #7664: Newfeature2/geode 9484
Posted by GitBox <gi...@apache.org>.
mivanac commented on PR #7664:
URL: https://github.com/apache/geode/pull/7664#issuecomment-1156600848
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett
just a reminder,
could you review this PR.
This was reverted PR with modifications for failing internal test.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #7664: Newfeature2/geode 9484
Posted by GitBox <gi...@apache.org>.
mivanac commented on PR #7664:
URL: https://github.com/apache/geode/pull/7664#issuecomment-1139687960
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett
just a reminder,
could you review this PR.
This was reverted PR with modifications for failing internal test.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on pull request #7664: Newfeature2/geode 9484
Posted by GitBox <gi...@apache.org>.
mivanac commented on PR #7664:
URL: https://github.com/apache/geode/pull/7664#issuecomment-1129874140
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett
could you review this PR.
This was reverted PR with modifications for failing internal test.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7664: Newfeature2/geode 9484
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on code in PR #7664:
URL: https://github.com/apache/geode/pull/7664#discussion_r908656969
##########
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/UpdatePropagationDistributedTest.java:
##########
@@ -258,7 +309,7 @@ private Integer createServerCache() throws Exception {
server.setPort(port);
server.setNotifyBySubscription(true);
server.start();
- return server.getPort();
+ return new Integer(server.getPort());
Review Comment:
Unnecessary explicit integer boxing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org