You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/01/30 00:47:08 UTC

Review Request 42987: Renamed a parameter for the sake of clarity.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42987/
-----------------------------------------------------------

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
-------

We use several different "timeouts" in this code and the "Zk session timeout"
has a very specific meaning in this context.


Diffs
-----

  src/zookeeper/group.hpp cf82fec290a2fa9bec122539c2eb0f12b45c2fb2 
  src/zookeeper/group.cpp 2ae3193e0e138c90b205d45400d80e80853e1b99 
  src/zookeeper/zookeeper.hpp 573ff5bca56cbb7efb98f6eb4f1796a2bc176b5e 
  src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8 

Diff: https://reviews.apache.org/r/42987/diff/


Testing
-------

make check


Thanks,

Neil Conway

Re: Review Request 42987: Renamed a parameter for the sake of clarity.

Posted by Joris Van Remoortere <jo...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42987/#review117122
-----------------------------------------------------------


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 29, 2016, 11:47 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42987/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 11:47 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We use several different "timeouts" in this code and the "Zk session timeout"
> has a very specific meaning in this context.
> 
> 
> Diffs
> -----
> 
>   src/zookeeper/group.hpp cf82fec290a2fa9bec122539c2eb0f12b45c2fb2 
>   src/zookeeper/group.cpp 2ae3193e0e138c90b205d45400d80e80853e1b99 
>   src/zookeeper/zookeeper.hpp 573ff5bca56cbb7efb98f6eb4f1796a2bc176b5e 
>   src/zookeeper/zookeeper.cpp 3c4fdad972dcd1728c52a05970646c713dcf98c8 
> 
> Diff: https://reviews.apache.org/r/42987/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>