[jira] [Commented] (COLLECTIONS-840) Make EnhancedDoubleHasher.mod() public

["Alex Herbert (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COLLECTIONS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731201#comment-17731201 ] 

Alex Herbert commented on COLLECTIONS-840:
------------------------------------------

I am not sure EnhancedDoubleHasher is the correct place for such a public utility method. I.e. Why this hasher and not any other hasher added later, other than precedence?

However the package has few utility classes. I do not think Shape is the correct place for it. Perhaps BitMap?
{code:java}
long h = ... // from some hash
int size = ... // BitMap size (positive)
int bit = BitMap.modulus(h, size); 
{code}

> Make EnhancedDoubleHasher.mod() public
> --------------------------------------
>
>                 Key: COLLECTIONS-840
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-840
>             Project: Commons Collections
>          Issue Type: Improvement
>          Components: Collection
>    Affects Versions: 4.5
>            Reporter: Claude Warren
>            Priority: Minor
>
> The integer modulus calculation is currently package private but is very useful outside of the package for further Bloom filter development.  This change is to make the static EnhancedDoubleHasher.mod() method public



--
This message was sent by Atlassian Jira
(v8.20.10#820010)